Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-26 Thread duke
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote: >> Integer.stringSize and Long.stringSize are used not only in java.lang, but >> also in other places. We put stringSize in DecimalDigits to reduce duplicate >> code and the use of JLA. > > Shaojin Wen has updated the pull request incremental

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Roger Riggs
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote: >> Integer.stringSize and Long.stringSize are used not only in java.lang, but >> also in other places. We put stringSize in DecimalDigits to reduce duplicate >> code and the use of JLA. > > Shaojin Wen has updated the pull request incremental

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Shaojin Wen
On Thu, 25 Jul 2024 14:48:29 GMT, Roger Riggs wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused Integer.stringSize & Long.stringSize > > What is the performance difference between the long and int versio

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 14:48:29 GMT, Roger Riggs wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused Integer.stringSize & Long.stringSize > > What is the performance difference between the long and int versio

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Roger Riggs
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote: >> Integer.stringSize and Long.stringSize are used not only in java.lang, but >> also in other places. We put stringSize in DecimalDigits to reduce duplicate >> code and the use of JLA. > > Shaojin Wen has updated the pull request incremental

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote: >> Integer.stringSize and Long.stringSize are used not only in java.lang, but >> also in other places. We put stringSize in DecimalDigits to reduce duplicate >> code and the use of JLA. > > Shaojin Wen has updated the pull request incremental

Re: RFR: 8337167: StringSize deduplication [v2]

2024-07-25 Thread Shaojin Wen
> Integer.stringSize and Long.stringSize are used not only in java.lang, but > also in other places. We put stringSize in DecimalDigits to reduce duplicate > code and the use of JLA. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: re

Re: RFR: 8337167: StringSize deduplication

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 05:30:34 GMT, Shaojin Wen wrote: > Integer.stringSize and Long.stringSize are used not only in java.lang, but > also in other places. We put stringSize in DecimalDigits to reduce duplicate > code and the use of JLA. src/java.base/share/classes/jdk/internal/access/JavaLangAc

Re: RFR: 8337167: StringSize deduplication

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 05:30:34 GMT, Shaojin Wen wrote: > Integer.stringSize and Long.stringSize are used not only in java.lang, but > also in other places. We put stringSize in DecimalDigits to reduce duplicate > code and the use of JLA. src/java.base/share/classes/java/lang/Integer.java line 47

RFR: 8337167: StringSize deduplication

2024-07-24 Thread Shaojin Wen
Integer.stringSize and Long.stringSize are used not only in java.lang, but also in other places. We put stringSize in DecimalDigits to reduce duplicate code and the use of JLA. - Commit messages: - stringSize deduplication Changes: https://git.openjdk.org/jdk/pull/20322/files We