Re: RFR: 8336927: Missing equals and hashCode in java.lang.classfile.Annotation [v2]

2024-07-23 Thread Adam Sotona
On Tue, 23 Jul 2024 15:43:42 GMT, Chen Liang wrote: >> Convert `AnnotationImpl` to a record so it comes with proper `equals` and >> `hashCode` implementations. This also fixes the comparison for >> annotation-valued annotation element values. > > Chen Liang has updated the pull request with a n

Re: RFR: 8336927: Missing equals and hashCode in java.lang.classfile.Annotation [v2]

2024-07-23 Thread Chen Liang
> Convert `AnnotationImpl` to a record so it comes with proper `equals` and > `hashCode` implementations. This also fixes the comparison for > annotation-valued annotation element values. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8336927: Missing equals and hashCode in java.lang.classfile.Annotation

2024-07-23 Thread Adam Sotona
On Tue, 23 Jul 2024 04:44:57 GMT, Chen Liang wrote: > Convert `AnnotationImpl` to a record so it comes with proper `equals` and > `hashCode` implementations. This also fixes the comparison for > annotation-valued annotation element values. Looks good to me, thanks for the fix. -

RFR: 8336927: Missing equals and hashCode in java.lang.classfile.Annotation

2024-07-22 Thread Chen Liang
Convert `AnnotationImpl` to a record so it comes with proper `equals` and `hashCode` implementations. This also fixes the comparison for annotation-valued annotation element values. - Commit messages: - 8336927: Missing equals and hashCode in java.lang.classfile.Annotation Changes