On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Tue, 1 Oct 2024 16:20:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/zip/ZipError.java line 31:
>>
>>> 29: * Signals that an unrecoverable error has occurred.
>>> 30: *
>>> 31: * @deprecated ZipError is no longer used and is obsolete.
>>
>> I agree ZipError should be d
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Tue, 1 Oct 2024 16:12:57 GMT, Alan Bateman wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commit
On Tue, 1 Oct 2024 15:50:59 GMT, ExE Boss wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits si
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Wed, 28 Aug 2024 15:12:13 GMT, Eirik Bjørsnøs wrote:
>>> I think linking to the CSR would be fine, but there is no prerequisite for
>>> API specs to link to CSRs. Need @jddarcy to double check here. I was
>>> emulating `Thread.stop`:
>>>
>>> https://github.com/openjdk/jdk/blob/5671f836039ef
On Wed, 28 Aug 2024 15:12:13 GMT, Eirik Bjørsnøs wrote:
>>> I think linking to the CSR would be fine, but there is no prerequisite for
>>> API specs to link to CSRs. Need @jddarcy to double check here. I was
>>> emulating `Thread.stop`:
>>>
>>> https://github.com/openjdk/jdk/blob/5671f836039ef
On Sun, 25 Aug 2024 13:36:18 GMT, Lance Andersen wrote:
>> I think linking to the CSR would be fine, but there is no prerequisite for
>> API specs to link to CSRs. Need @jddarcy to double check here. I was
>> emulating `Thread.stop`:
>> https://github.com/openjdk/jdk/blob/5671f836039ef1683e3e9
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Wed, 28 Aug 2024 08:11:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not explain the reason for the deprecation in detail, but instead
On Tue, 27 Aug 2024 20:37:12 GMT, Lance Andersen wrote:
> Other options could be:
>
> _ZipError is obsolete and is no longer used. ZipException should be used
> instead_
This looks good to me! I've pushed this with a an empty line above to visually
separate the class description from the java
On Tue, 27 Aug 2024 19:49:01 GMT, Eirik Bjørsnøs wrote:
> > The javadoc should be focused on the current JDK release, not the prior
> > history of this Class
>
> Makes sense, let's focus on the current release.
>
> > ```
> > * @deprecated ZipError is deprecated and subject to removal in a
> >
On Tue, 27 Aug 2024 17:24:42 GMT, Lance Andersen wrote:
> The javadoc should be focused on the current JDK release, not the prior
> history of this Class
Makes sense, let's focus on the current release.
> ```
> * @deprecated ZipError is deprecated and subject to removal in a
> * future rele
On Tue, 27 Aug 2024 15:51:24 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Tue, 27 Aug 2024 15:51:24 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
On Tue, 27 Aug 2024 15:51:24 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which suggests to deprecate the unused class
>> `java.util.zip.ZipError` for removal.
>>
>> The class has been unsed by OpenJDK since the ZIP API was rewritten from
>> native to Java in JDK 9.
>>
>> I opted to n
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not explain the reason for the deprecation in detail, but instead
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Sat, 24 Aug 2024 17:22:28 GMT, Chen Liang wrote:
> I think linking to the CSR would be fine, but there is no prerequisite for
> API specs to link to CSRs. Need @jddarcy to double check here. I was
> emulating `Thread.stop`:
>
> https://github.com/openjdk/jdk/blob/5671f836039ef1683e3e9ce5b7c
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Sat, 24 Aug 2024 10:16:55 GMT, Eirik Bjørsnøs wrote:
>> On a corpus search, found
>> org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/AddJarFileToIndex.java
>> references ZipError (16 usages)
>>
>> sbt/internal/inc/zip/ZipCentralDir.java referenced ZipError(was based
On Sat, 24 Aug 2024 10:16:55 GMT, Eirik Bjørsnøs wrote:
>> On a corpus search, found
>> org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/AddJarFileToIndex.java
>> references ZipError (16 usages)
>>
>> sbt/internal/inc/zip/ZipCentralDir.java referenced ZipError(was based
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Fri, 23 Aug 2024 19:13:23 GMT, Lance Andersen wrote:
> So would be good to also alert those projects if possible
I guess the deprecation warning itself is the "official" channel for
communicating this type of information. But I agree it doesn't hurt to alert at
least some of the larger proj
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which suggests to deprecate the unused class
> `java.util.zip.ZipError` for removal.
>
> The class has been unsed by OpenJDK since the ZIP API was rewritten from
> native to Java in JDK 9.
>
> I opted to not expl
Please review this PR which suggests to deprecate the unused class
`java.util.zip.ZipError` for removal.
The class has been unsed by OpenJDK since the ZIP API was rewritten from
native to Java in JDK 9.
I opted to not explain the reason for the deprecation in detail, but instead
simply point
32 matches
Mail list logo
