Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-19 Thread duke
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder @wenshao Your change (at version db3027b03030304dbec990c943eff0f037363e37) is

Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-19 Thread Chen Liang
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder Tier 1-3 tests come back all passing as well. - PR Comment: http

Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-19 Thread Naoto Sato
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder Marked as reviewed by naoto (Reviewer). - PR Review: https://git

Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-19 Thread Roger Riggs
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder lgtm - Marked as reviewed by rriggs (Reviewer). PR Review: http

Re: RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 23:36:37 GMT, Shaojin Wen wrote: > The StringBuilder.repeat method was added in JDK 21, which can be used to > make some minor optimizations to existing code, including > DateTimeFormatterBuilder Looks good and simple. - Marked as reviewed by liach (Reviewer).

RFR: 8336792: DateTimeFormatterBuilder append zeros based on StringBuilder.repeat

2024-07-18 Thread Shaojin Wen
The StringBuilder.repeat method was added in JDK 21, which can be used to make some minor optimizations to existing code, including DateTimeFormatterBuilder - Commit messages: - use StringBuilder#repeat append zeros Changes: https://git.openjdk.org/jdk/pull/20245/files Webrev: ht