Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v30]

2024-11-21 Thread Viktor Klang
On Tue, 19 Nov 2024 22:51:04 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Doug Lea
On Wed, 20 Nov 2024 10:36:13 GMT, Viktor Klang wrote: >> resetThreadLocals looks good although. A discussion point is whether reset >> should be done for all FJP instances, not just the common pool but not this >> PR. > > Thanks Alan. Yes, I think it should be considered to do it for all FJP >

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Viktor Klang
On Tue, 19 Nov 2024 19:12:29 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 4082: >> >>> 4080: AccessController.doPrivileged(new PrivilegedAction<>() { >>> 4081: public ForkJoinPool run() { >>> 4082:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Viktor Klang
On Wed, 20 Nov 2024 08:11:34 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java >> line 247: >> >>> 245: = U.objectFieldOffset(Thread.class, "threadLocals"); >>> 246: private static final long INHERITABLETHREADLOCALS >>> 247:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-20 Thread Alan Bateman
On Tue, 19 Nov 2024 16:57:05 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v30]

2024-11-19 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Viktor Klang
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:54:04 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:52:44 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Doug Lea
On Tue, 19 Nov 2024 16:10:19 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager > > src/java.base/share/classes/java/util/concu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-19 Thread Viktor Klang
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

2024-11-18 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v28]

2024-11-16 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v27]

2024-11-13 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v26]

2024-11-13 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v26]

2024-11-13 Thread Doug Lea
On Wed, 13 Nov 2024 08:55:19 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename variable > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2617: > >> 2615:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v25]

2024-11-13 Thread Viktor Klang
On Tue, 12 Nov 2024 21:48:54 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v24]

2024-11-12 Thread Doug Lea
On Tue, 12 Nov 2024 14:14:18 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1870: > >> 1868:

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v25]

2024-11-12 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v24]

2024-11-12 Thread Viktor Klang
On Mon, 11 Nov 2024 16:39:47 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v24]

2024-11-12 Thread Viktor Klang
On Mon, 11 Nov 2024 16:39:47 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v24]

2024-11-11 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v23]

2024-11-11 Thread Viktor Klang
On Mon, 11 Nov 2024 16:01:08 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v23]

2024-11-11 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v22]

2024-11-11 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v21]

2024-11-11 Thread Viktor Klang
On Sun, 10 Nov 2024 17:51:43 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v21]

2024-11-10 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v20]

2024-11-09 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v19]

2024-11-09 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v18]

2024-11-06 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v17]

2024-11-04 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v16]

2024-11-03 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v15]

2024-11-02 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v14]

2024-11-01 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v13]

2024-10-28 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v12]

2024-10-28 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v11]

2024-10-28 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v10]

2024-10-27 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v9]

2024-10-26 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v8]

2024-10-26 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v7]

2024-10-25 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v5]

2024-10-25 Thread Viktor Klang
On Thu, 24 Oct 2024 20:41:46 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v5]

2024-10-25 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v6]

2024-10-24 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v4]

2024-10-23 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v3]

2024-10-21 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v2]

2024-10-19 Thread Doug Lea
On Fri, 18 Oct 2024 15:47:16 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Better disinguish need for exhaustive scans > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 200

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v2]

2024-10-18 Thread Viktor Klang
On Fri, 18 Oct 2024 15:18:12 GMT, Doug Lea wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> reduce o

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v2]

2024-10-18 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-18 Thread Doug Lea
On Wed, 16 Oct 2024 16:38:13 GMT, Viktor Klang wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> redu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-18 Thread Viktor Klang
On Fri, 18 Oct 2024 12:32:21 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1287: >> >>> 1285: if (!internal) >>> 1286: unlockPhase(); >>> 1287: if ((room == 0 || U.getReference(a, pk) == null) && pool >>>

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-18 Thread Viktor Klang
On Fri, 18 Oct 2024 12:27:34 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1913: >> >>> 1911: if (!all) >>> 1912: break; >>> 1913: } >> >> Stylistically, it might be cleaner to do this: >> >> Sugg

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-18 Thread Doug Lea
On Wed, 16 Oct 2024 16:32:32 GMT, Viktor Klang wrote: >> This addresses tendencies in previous update to increase fencing, scanning, >> and signalling that can increase contention, and slow down performance >> especially on ARM platforms. It also uses more ARM-friendly constructions to >> redu

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-16 Thread Viktor Klang
On Mon, 14 Oct 2024 20:58:43 GMT, Doug Lea wrote: > This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overh

RFR: 8336707: Contention of ForkJoinPool grows when stealing works

2024-10-14 Thread Doug Lea
This addresses tendencies in previous update to increase fencing, scanning, and signalling that can increase contention, and slow down performance especially on ARM platforms. It also uses more ARM-friendly constructions to reduce overhead (leading to several changes that all of the same form),