Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Chen Liang
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros See https://openjdk.org/guide/#life-of-a-pr point 6 for the 24-hour wait rule. - PR Comment: https://git.openjdk.org/jdk

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Naoto Sato
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros As a general rule, please wait for at least 24 hours to integrate, for devs around the globe to take a look (unless emergency such as

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread duke
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros @wenshao Your change (at version a98bd05c857d0a04dfad471dd28f905be1345376) is now ready to be sponsored by a Committer. ---

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Naoto Sato
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-2157610512

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Justin Lu
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros +1 - Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-2157583

Re: RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Chen Liang
On Wed, 3 Jul 2024 21:43:05 GMT, Shaojin Wen wrote: > In JDK 21, StringBuilder added a repeat method, which can be used to improve > j.u.Formatter#trailingZeros Marked as reviewed by liach (Committer). - PR Review: https://git.openjdk.org/jdk/pull/20018#pullrequestreview-215753437

RFR: 8335645: j.u.Formatter#trailingZeros improved with String repeat

2024-07-03 Thread Shaojin Wen
In JDK 21, StringBuilder added a repeat method, which can be used to improve j.u.Formatter#trailingZeros - Commit messages: - use StringBuilder#repeat Changes: https://git.openjdk.org/jdk/pull/20018/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20018&range=00 Issue: ht