Re: [jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-24 Thread Maurizio Cimadamore
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-23 Thread Hannes Greule
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-23 Thread Jaikiran Pai
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

[jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-22 Thread Hannes Greule
Hi all, This pull request contains a backport of commit [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Hannes Greule on 22 Jun 2024 and was re

Re: RFR: 8334708: FFM: two javadoc problems

2024-06-21 Thread Maurizio Cimadamore
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote: > Addresses two simple problems regarding javadocs in the FFM API. Yes, javadoc fixes such as this can be backported. Just use the `/backport` command: https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/backp

Re: RFR: 8334708: FFM: two javadoc problems

2024-06-21 Thread Chen Liang
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote: > Addresses two simple problems regarding javadocs in the FFM API. I think we can safely backport this to 23, as this is a doc-only fix (I've labeled the JBS issue noreg-doc as well) allowed by JEP-3 for RDP 1 and 2. - PR Comm

Re: RFR: 8334708: FFM: two javadoc problems

2024-06-21 Thread Hannes Greule
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote: > Addresses two simple problems regarding javadocs in the FFM API. Thank you for your review. > Should we backport to 23? I leave that up to you, I don't know how those things are handled normally. But a backport would be very simple in t

Re: RFR: 8334708: FFM: two javadoc problems

2024-06-21 Thread Maurizio Cimadamore
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote: > Addresses two simple problems regarding javadocs in the FFM API. Thanks! Should we backport to 23? - Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19820#pullrequestreview-213215539

RFR: 8334708: FFM: two javadoc problems

2024-06-21 Thread Hannes Greule
Addresses two simple problems regarding javadocs in the FFM API. - Commit messages: - fix two javadoc problems in FFM Changes: https://git.openjdk.org/jdk/pull/19820/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19820&range=00 Issue: https://bugs.openjdk.org/browse/JDK-