Re: RFR: 8334394: Race condition in Class::protectionDomain [v3]

2024-07-22 Thread Roger Riggs
On Mon, 22 Jul 2024 12:42:48 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with two additional > commits since the last revision: > > - var to real type > - rename Marked as

Re: RFR: 8334394: Race condition in Class::protectionDomain [v3]

2024-07-22 Thread Chen Liang
On Mon, 22 Jul 2024 12:42:48 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with two additional > commits since the last revision: > > - var to real type > - rename Marked as

Re: RFR: 8334394: Race condition in Class::protectionDomain [v3]

2024-07-22 Thread Jaikiran Pai
On Mon, 22 Jul 2024 12:42:48 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with two additional > commits since the last revision: > > - var to real type > - rename Still look

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-07-22 Thread Weijun Wang
On Tue, 16 Jul 2024 12:59:36 GMT, Alan Bateman wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> explain why the test is related to the fix > > test/jdk/java/lang/Class/ProtectionDomainRace.java line 61: > >> 59:

Re: RFR: 8334394: Race condition in Class::protectionDomain [v3]

2024-07-22 Thread Weijun Wang
> Make sure `pd` is always the same object when `getProtectionDomain0` is null. Weijun Wang has updated the pull request incrementally with two additional commits since the last revision: - var to real type - rename - Changes: - all: https://git.openjdk.org/jdk/pull/19752/files

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-07-18 Thread Roger Riggs
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-07-16 Thread Alan Bateman
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-07-12 Thread Jaikiran Pai
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-06-23 Thread Chen Liang
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-06-17 Thread Alan Bateman
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-06-17 Thread Weijun Wang
> Make sure `pd` is always the same object when `getProtectionDomain0` is null. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: explain why the test is related to the fix - Changes: - all: https://git.openjdk.org/jdk/pu

Re: RFR: 8334394: Race condition in Class::protectionDomain

2024-06-17 Thread Weijun Wang
On Mon, 17 Jun 2024 15:11:29 GMT, Weijun Wang wrote: >> test/jdk/java/lang/Class/ProtectionDomainRace.java line 42: >> >>> 40: try { >>> 41: Subject.doAs(null, ac); >>> 42: } catch (Throwable t) { >> >> This can test for the racy NPE, but it c

Re: RFR: 8334394: Race condition in Class::protectionDomain

2024-06-17 Thread Weijun Wang
On Mon, 17 Jun 2024 15:08:26 GMT, Chen Liang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > test/jdk/java/lang/Class/ProtectionDomainRace.java line 42: > >> 40: try { >> 41: Subject.doAs(null, ac); >> 42:

Re: RFR: 8334394: Race condition in Class::protectionDomain

2024-06-17 Thread Chen Liang
On Mon, 17 Jun 2024 14:51:07 GMT, Weijun Wang wrote: > Make sure `pd` is always the same object when `getProtectionDomain0` is null. test/jdk/java/lang/Class/ProtectionDomainRace.java line 42: > 40: try { > 41: Subject.doAs(null, ac); > 42: }

Re: RFR: 8334394: Race condition in Class::protectionDomain

2024-06-17 Thread Chen Liang
On Mon, 17 Jun 2024 14:51:07 GMT, Weijun Wang wrote: > Make sure `pd` is always the same object when `getProtectionDomain0` is null. Looks great! I just wonder about how we usually write tests for such races, as these races may be platform-dependent and the test might not be able to always rep

RFR: 8334394: Race condition in Class::protectionDomain

2024-06-17 Thread Weijun Wang
Make sure `pd` is always the same object when `getProtectionDomain0` is null. - Commit messages: - chmod - the fix Changes: https://git.openjdk.org/jdk/pull/19752/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19752&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83