On Wed, 26 Jun 2024 11:30:25 GMT, Raffaello Giulietti
wrote:
>> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
>
> @wenshao Looks good, thanks for the improvements.
>
> Let me know when you are finished with your changes.
> Once approved, you should refrain from addi
On Tue, 25 Jun 2024 01:58:29 GMT, Shaojin Wen wrote:
>> Just suggesting some improvements
>
> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
@wenshao Looks good, thanks for the improvements.
Let me know when you are finished with your changes.
Once approved, you shou
On Sun, 16 Jun 2024 21:25:42 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> Just suggesting some improvements
All suggestions have been fixed, can this PR be integrated? @cl4es
On Sun, 16 Jun 2024 21:00:41 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 171:
>
>> 169: /* Using the dep
On Sun, 16 Jun 2024 23:49:18 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 169:
>>
>>> 167: }
>>> 168:
>>> 169: /* Using the deprecated constructor enhances performance */
>>
>> Enhances performance over what, `new String(str, 0, index,
>
On Sun, 16 Jun 2024 21:02:09 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 169:
>
>> 167: }
>> 168:
>> 16
On Sat, 15 Jun 2024 13:27:41 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
