On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Mon, 15 Jul 2024 16:02:49 GMT, Jaikiran Pai wrote:
> > Does this PR need 2rd reviewer.
>
> core-libs area doesn't mandate 2 reviews. The current PR is a test
> infrastructure change and doesn't impact the functionality of the test. The
> change has been tested in our CI and appears to work
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Mon, 15 Jul 2024 15:29:03 GMT, SendaoYan wrote:
> Does this PR need 2rd reviewer.
core-libs area doesn't mandate 2 reviews. The current PR is a test
infrastructure change and doesn't impact the functionality of the test. The
change has been tested in our CI and appears to work fine without
On Fri, 12 Jul 2024 07:04:33 GMT, Jaikiran Pai wrote:
> What you propose in this PR looks fine to me and matches some other tests
> which do a similar thing. Maybe we should do the same thing in some other
> tests in this directory, to keep them consistent. For now though, I think
> what you h
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to
>> [JDK-8157850](https://
On Fri, 12 Jul 2024 07:05:58 GMT, Jaikiran Pai wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make variable TOOL_VM_OPTIONS to private
>
> test/jdk/tools/jlink/JLinkReproducibleTest.java line 41:
>
>> 39: public cla
> Hi all,
> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
> doesn't receive jvm options from jtreg.
> I think it's necessory to receive jvm options from jtreg.
> Fix solution similar to
> [JDK-8157850](https://bugs.openjdk.org/browse/JDK-8157850), the change has
> bee
On Fri, 12 Jul 2024 07:05:34 GMT, Jaikiran Pai wrote:
> I'll run this change against our CI instance just to be sure this doesn't
> cause unexpected issues. I'll approve the PR once those runs complete.
Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/19669#issuecomment-2224
On Wed, 12 Jun 2024 02:00:41 GMT, SendaoYan wrote:
> Hi all,
> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
> doesn't receive jvm options from jtreg.
> I think it's necessory to receive jvm options from jtreg.
> Fix solution similar to
> [JDK-8157850](https://bugs.o
On Wed, 12 Jun 2024 02:00:41 GMT, SendaoYan wrote:
> Hi all,
> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
> doesn't receive jvm options from jtreg.
> I think it's necessory to receive jvm options from jtreg.
> Fix solution similar to
> [JDK-8157850](https://bugs.o
On Wed, 10 Jul 2024 06:12:56 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> The change has been verified, only change the test
On Wed, 10 Jul 2024 06:12:56 GMT, SendaoYan wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
>> doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> The change has been verified, only change the test
On Wed, 12 Jun 2024 02:00:41 GMT, SendaoYan wrote:
> Hi all,
> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
> doesn't receive jvm options from jtreg.
> I think it's necessory to receive jvm options from jtreg.
> The change has been verified, only change the testacase
Hi all,
Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java`
doesn't receive jvm options from jtreg.
I think it's necessory to receive jvm options from jtreg.
The change has been verified, only change the testacase, the risk is low.
-
Commit messages:
- 8334057:
17 matches
Mail list logo
