Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v5]

2024-07-15 Thread Raffaello Giulietti
On Sat, 13 Jul 2024 22:44:31 GMT, Joe Darcy wrote: >> Misc small doc updates and addition of `@Overrides` annotations. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v5]

2024-07-13 Thread Joe Darcy
> Misc small doc updates and addition of `@Overrides` annotations. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits si

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v4]

2024-07-13 Thread Joe Darcy
On Wed, 19 Jun 2024 01:43:27 GMT, Joe Darcy wrote: >> Misc small doc updates and addition of `@Overrides` annotations. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Added some typographical updat

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v5]

2024-07-13 Thread Joe Darcy
On Wed, 19 Jun 2024 14:22:38 GMT, Raffaello Giulietti wrote: > Take the `double` closest to the exact decimal 0.1. > > My understanding is that IEEE with a precision of 17 would convert it to the > decimal 0.10001. > > However, `Formatter` with a specifier `"%.17f"` will render th

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v4]

2024-06-19 Thread Raffaello Giulietti
On Wed, 19 Jun 2024 01:49:47 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/lang/Double.java line 595: >> >>> 593: * This method corresponds to the convertToDecimalCharacter >>> 594: * operation defined in IEEE 754. >>> 595: * >> >> Does it? >> >> IEEE 754 `convertToD

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v4]

2024-06-18 Thread Joe Darcy
On Fri, 7 Jun 2024 12:48:51 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/java.base/share/classes/java/lang/Double.java line 595: > >> 593: * This

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v4]

2024-06-18 Thread Joe Darcy
> Misc small doc updates and addition of `@Overrides` annotations. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/19590/files - new: https:

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v3]

2024-06-18 Thread Joe Darcy
> Misc small doc updates and addition of `@Overrides` annotations. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits si

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double} [v2]

2024-06-10 Thread Joe Darcy
> Misc small doc updates and addition of `@Overrides` annotations. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits sinc

Re: RFR: 8333768: Minor doc updates to java.lang.{Float, Double}

2024-06-07 Thread Raffaello Giulietti
On Fri, 7 Jun 2024 04:47:12 GMT, Joe Darcy wrote: > Misc small doc updates and addition of `@Overrides` annotations. src/java.base/share/classes/java/lang/Double.java line 595: > 593: * This method corresponds to the convertToDecimalCharacter > 594: * operation defined in IEEE 754. >

RFR: 8333768: Minor doc updates to java.lang.{Float, Double}

2024-06-06 Thread Joe Darcy
Misc small doc updates and addition of `@Overrides` annotations. - Commit messages: - JDK-8333768: Minor doc updates to java.lang.{Float, Double} Changes: https://git.openjdk.org/jdk/pull/19590/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19590&range=00 Issue: https://