On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 11 Sep 2024 14:13:50 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and cgroups v2 (since
> [JDK-8322420](https://bugs.o
On Tue, 10 Sep 2024 13:23:45 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> co
On Tue, 10 Sep 2024 13:23:37 GMT, Severin Gehwolf wrote:
>> Looking through the coding it looks more or less okay to me; but if you
>> really need to run it under user 'root' I think we will not have so much
>> use for this in our test environments because we use other test users.
>> Not sayi
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Tue, 10 Sep 2024 12:12:50 GMT, Zdenek Zambersky wrote:
> I have just added `cpu` to Delegate list of `user@.service`, looks similar,
> to what is done there. I see use of `Delegate=yes` in your link, that
> probably delegates all.
> Thanks for this link.
FWIW, I was able to reproduce what y
On Mon, 9 Sep 2024 17:28:16 GMT, Zdenek Zambersky wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> com
On Mon, 9 Sep 2024 17:28:16 GMT, Zdenek Zambersky wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> com
On Wed, 4 Sep 2024 17:46:00 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> co
On Wed, 4 Sep 2024 17:46:00 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> co
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Fri, 30 Aug 2024 11:40:45 GMT, Severin Gehwolf wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2507:
>>
>>> 2505: WB_END
>>> 2506:
>>> 2507: // Physical cpus of the host machine (including containers), Linux
>>> only.
>>
>> Isn't the comment a bit misleading ? From what I see , `
>>
On Fri, 30 Aug 2024 14:14:05 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Fri, 30 Aug 2024 11:46:51 GMT, Severin Gehwolf wrote:
> > Not saying that this is a very bad thing, maybe it is just the way it is,
> > that 'root' is needed ?
>
> I'll do some more research whether or not that is a hard requirement. Thanks
> for the comments so far.
It turns out it works
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken wrote:
> Not saying that this is a very bad thing, maybe it is just the way it is,
> that 'root' is needed ?
I'll do some more research whether or not that is a hard requirement. Thanks
for the comments so far.
-
PR Comment: http
On Fri, 30 Aug 2024 11:02:52 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> co
On Wed, 28 Aug 2024 16:13:07 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 28 Aug 2024 16:13:07 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 28 Aug 2024 16:13:07 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Thu, 29 Aug 2024 15:22:02 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> co
On Wed, 28 Aug 2024 16:13:07 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Wed, 28 Aug 2024 14:21:09 GMT, Zdenek Zambersky wrote:
> > > If I am not mistaken, new test requires, that testsuite is ran as
> > > superuser (root). (Because it writes `/etc/systemd/system`, runs certain
> > > systemd commands). Should test be skipped for non-root?
> >
> >
> > Thanks! I
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Tue, 27 Aug 2024 15:01:59 GMT, Severin Gehwolf wrote:
> > If I am not mistaken, new test requires, that testsuite is ran as superuser
> > (root). (Because it writes `/etc/systemd/system`, runs certain systemd
> > commands). Should test be skipped for non-root?
>
> Thanks! I can add that. FW
On Tue, 27 Aug 2024 14:24:18 GMT, Matthias Baesken wrote:
> I added the PR to our internal build/test queue .
Thanks, Matthias!
-
PR Comment: https://git.openjdk.org/jdk/pull/19530#issuecomment-2312813813
On Tue, 27 Aug 2024 14:12:40 GMT, Zdenek Zambersky wrote:
> If I am not mistaken, new test requires, that testsuite is ran as superuser
> (root). (Because it writes `/etc/systemd/system`, runs certain systemd
> commands). Should test be skipped for non-root?
Thanks! I can add that. FWIW, conta
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Fri, 12 Jul 2024 12:28:16 GMT, Jan Kratochvil
wrote:
> With #17198 and this updated patch I still get the a FAIL due to:
>
> ```
> [0.333s][trace][os,container] OSContainer::active_processor_count: 4
> ```
>
> But let's resolve it after #17198 gets final/approved.
Because the #17198 is inc
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Thu, 11 Jul 2024 14:26:23 GMT, Jan Kratochvil
wrote:
> > > ```
> > > * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> > > properly distributes the load but JDK still sees all available CPU cores
> > > (4 of my VM).
> > > ```
> >
> >
> > Could you elaborate on that? W
On Thu, 11 Jul 2024 09:23:58 GMT, Severin Gehwolf wrote:
> > ```
> > * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> > properly distributes the load but JDK still sees all available CPU cores (4
> > of my VM).
> > ```
>
> Could you elaborate on that? What does not work?
On Thu, 11 Jul 2024 03:42:27 GMT, Jan Kratochvil
wrote:
> [test.patch.txt](https://github.com/user-attachments/files/16171122/test.patch.txt)
>
> * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> properly distributes the load but JDK still sees all available CPU cores
On Thu, 11 Jul 2024 03:39:37 GMT, Jan Kratochvil
wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> c
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Thu, 20 Jun 2024 08:34:45 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
On Mon, 3 Jun 2024 17:28:09 GMT, Severin Gehwolf wrote:
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroup
Please review this PR which adds test support for systemd slices so that bugs
like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
cgroups v1 and fails on cgroups v2 due to the way how
[JDK-8217338](htt
56 matches
Mail list logo
