Re: [jdk23] RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-24 Thread SendaoYan
On Sun, 23 Jun 2024 15:11:52 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [1b1dba80](https://github.com/openjdk/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk23] RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-24 Thread SendaoYan
On Sun, 23 Jun 2024 15:11:52 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [1b1dba80](https://github.com/openjdk/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk23] RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-24 Thread Pavel Rappo
On Sun, 23 Jun 2024 15:11:52 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [1b1dba80](https://github.com/openjdk/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk23] RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-23 Thread SendaoYan
Hi all, This pull request contains a backport of commit [1b1dba80](https://github.com/openjdk/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Pavel Rappo on 20 Jun 2024 and was revi

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v5]

2024-06-20 Thread Naoto Sato
On Thu, 20 Jun 2024 09:56:45 GMT, Pavel Rappo wrote: >> Please review this fix for an intermittent test failure. >> >> On some configurations, the default `expect` timeout of 10 seconds is >> insufficient. It is increased to 20; it's hard to imagine a configuration >> for which that new value

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v5]

2024-06-20 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v4]

2024-06-13 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

2024-06-13 Thread Pavel Rappo
On Thu, 13 Jun 2024 06:47:07 GMT, Jaikiran Pai wrote: > in the past on systems that Matthias has run into similar issues, it was > observed that those systems run with a very high `-concurrency` value (which > implies too many test processes running at the same time) which could cause > slowne

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Jaikiran Pai
On Thu, 13 Jun 2024 08:05:15 GMT, Alan Bateman wrote: >> Looking briefly at this, I think we should be able to provide this as a >> feature of jtreg's support of `junit` test itself. I've created >> https://bugs.openjdk.org/browse/CODETOOLS-7903751 to investigate this >> support in jtreg. > >

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Alan Bateman
On Thu, 13 Jun 2024 06:59:39 GMT, Jaikiran Pai wrote: >> test/jdk/java/io/IO/IO.java line 192: >> >>> 190: // adapted from >>> https://junit.org/junit5/docs/current/user-guide/#extensions-lifecycle-callbacks-timing-extension >>> 191: >>> 192: public static class TimingExtension impleme

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-13 Thread Jaikiran Pai
On Thu, 13 Jun 2024 06:29:36 GMT, Alan Bateman wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Disable timeout in expect scripts > > test/jdk/java/io/IO/IO.java line 192: > >> 190: // adapted from >> https://j

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

2024-06-12 Thread Jaikiran Pai
On Wed, 12 Jun 2024 19:02:30 GMT, Pavel Rappo wrote: > Preliminary testing on some affected configurations showed that even 20 > seconds might not be enough. Initially, I suggested that it would be hard to > imagine, yet here we are. I haven't seen the jtreg launch command or the jtr files for

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-12 Thread Alan Bateman
On Wed, 12 Jun 2024 19:06:23 GMT, Pavel Rappo wrote: >> Please review this fix for an intermittent test failure. >> >> On some configurations, the default `expect` timeout of 10 seconds is >> insufficient. It is increased to 20; it's hard to imagine a configuration >> for which that new value

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

2024-06-12 Thread Pavel Rappo
On Tue, 11 Jun 2024 09:01:49 GMT, Pavel Rappo wrote: >> Please review this fix for an intermittent test failure. >> >> On some configurations, the default `expect` timeout of 10 seconds is >> insufficient. It is increased to 20; it's hard to imagine a configuration >> for which that new value

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v3]

2024-06-12 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

2024-06-11 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-10 Thread Naoto Sato
On Mon, 10 Jun 2024 12:29:32 GMT, Pavel Rappo wrote: > Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would

RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-10 Thread Pavel Rappo
Please review this fix for an intermittent test failure. On some configurations, the default `expect` timeout of 10 seconds is insufficient. It is increased to 20; it's hard to imagine a configuration for which that new value would still be insufficient, but we'll see. Aside from that, test-gen