Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Thomas Stuefe
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) > enabling `javap -system` to handle internal class names. > > Thanks, > Sonia +1 - Marked as reviewed by stuefe (Reviewer

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Chen Liang
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) > enabling `javap -system` to handle internal class names. > > Thanks, > Sonia noreg means no regression test. Since we cannot really cr

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Sonia Zaldana Calles
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) > enabling `javap -system` to handle internal class names. > > Thanks, > Sonia Hi everyone, thanks for taking a look. Seeing the chall

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Jan Lahoda
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) > enabling `javap -system` to handle internal class names. > > Thanks, > Sonia For a test, I agree it is quite difficult. For the `--sys

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Thomas Stuefe
On Wed, 26 Jun 2024 07:54:16 GMT, Alan Bateman wrote: > > Question, what is the noreg-hard label used for? > > It's the label to mean that it's too hard or impossible write a regression > test. It is documented in the [JBS label > dictionary](https://openjdk.org/guide/#jbs-label-dictionary) bu

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-26 Thread Alan Bateman
On Wed, 26 Jun 2024 06:04:08 GMT, Thomas Stuefe wrote: > Question, what is the noreg-hard label used for? It's the label to mean that it's too hard or impossible write a regression test. It is documented in the [JBS label dictionary](https://openjdk.org/guide/#jbs-label-dictionary) but may not

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-25 Thread Thomas Stuefe
On Tue, 25 Jun 2024 19:49:07 GMT, Chen Liang wrote: > Technically javap accepts both notations of `a.b.C` and `a/b/C.class` and > accepts both `.` and `$` as inner class separators. So this is fine. However > it's hard to verify that the jdk in `--system` is really used, so I put a > noreg-har

Re: RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-25 Thread Chen Liang
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) > enabling `javap -system` to handle internal class names. > > Thanks, > Sonia Technically javap accepts both notations of `a.b.C` and `

RFR: 8333308: javap --system handling doesn't work on internal class names

2024-06-25 Thread Sonia Zaldana Calles
Hi all, This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808) enabling `javap -system` to handle internal class names. Thanks, Sonia - Commit messages: - 808: javap --system handling doesn't work on internal class names Changes: https://git.openjdk.o