Re: RFR: 8332154: Memory leak in SynchronousQueue

2024-05-21 Thread Viktor Klang
On Thu, 16 May 2024 21:36:03 GMT, Konstantin Nisht wrote: >> @AlanBateman @DougLea Reviews are most welcome :) > > @viktorklang-ora We managed to reproduce it quite reliably by running the > test from the bug report multiple times (in our case, it was 100). I > understand this does not make a 1

Re: RFR: 8332154: Memory leak in SynchronousQueue [v5]

2024-05-20 Thread Alan Bateman
On Mon, 20 May 2024 15:23:36 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. Regression test added for JDK20+ > > Viktor Klang has updated the pull request incrementally with one additional > commit

Re: RFR: 8332154: Memory leak in SynchronousQueue [v5]

2024-05-20 Thread Viktor Klang
> Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. Regression test added for JDK20+ Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Turn the Runnables into callables

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-20 Thread Viktor Klang
On Mon, 20 May 2024 14:49:13 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moving the memory leak test for SynchronousQueue into its own test and >> runs only for JDK20+, using VirtualThreads >

Re: RFR: 8332154: Memory leak in SynchronousQueue [v4]

2024-05-20 Thread Viktor Klang
> Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. Regression test added for JDK20+ Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Addressing review feedback --

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-20 Thread Alan Bateman
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. Regression test added for JDK20+ > > Viktor Klang has updated the pull request incrementally with one additional > commit

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Viktor Klang
On Fri, 17 May 2024 13:49:44 GMT, Doug Lea wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moving the memory leak test for SynchronousQueue into its own test and >> runs only for JDK20+, using VirtualThreads > > S

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Doug Lea
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Viktor Klang
> Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. > > But with that said, I haven't come up with a decent way of adding some form > of regression test. Suggestions are most welcome. /cc @DougLea Viktor Klang has updated the pul

Re: RFR: 8332154: Memory leak in SynchronousQueue [v2]

2024-05-17 Thread Viktor Klang
On Fri, 17 May 2024 11:52:12 GMT, Doug Lea wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding a leak detection test for SynchronousQueue > > Looks good; thanks. I don't know why I left out this check in a case

Re: RFR: 8332154: Memory leak in SynchronousQueue [v2]

2024-05-17 Thread Doug Lea
On Fri, 17 May 2024 11:39:32 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue [v2]

2024-05-17 Thread Viktor Klang
On Fri, 17 May 2024 11:35:55 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue [v2]

2024-05-17 Thread Viktor Klang
> Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. > > But with that said, I haven't come up with a decent way of adding some form > of regression test. Suggestions are most welcome. /cc @DougLea Viktor Klang has updated the pul

Re: RFR: 8332154: Memory leak in SynchronousQueue

2024-05-17 Thread Vitaly Provodin
On Thu, 16 May 2024 15:06:45 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue

2024-05-16 Thread Konstantin Nisht
On Thu, 16 May 2024 15:06:45 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue

2024-05-16 Thread Viktor Klang
On Thu, 16 May 2024 14:54:52 GMT, Viktor Klang wrote: > Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. > > But with that said, I haven't come up with a decent way of adding some form > of regression test. Suggestions are most

RFR: 8332154: Memory leak in SynchronousQueue

2024-05-16 Thread Viktor Klang
Local testing seems to indicate that this fix (which mirrors what's done in the FIFO mode) addresses the problem. But with that said, I haven't come up with a decent way of adding some form of regression test. Suggestions are most welcome. /cc @DougLea - Commit messages: - Memory