Re: RFR: 8331582: Incorrect default Console provider comment

2024-05-03 Thread Naoto Sato
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote: > Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Thank you for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/19070#issuecomment-2093318995

Re: RFR: 8331582: Incorrect default Console provider comment [v2]

2024-05-03 Thread Naoto Sato
> Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/java/io/Console.java Th

Re: RFR: 8331582: Incorrect default Console provider comment

2024-05-03 Thread Pavel Rappo
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote: > Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Looks good. src/java.base/share/classes/java/io/Console.java line 409: > 407: * The JdkConsole provider u

Re: RFR: 8331582: Incorrect default Console provider comment

2024-05-03 Thread Justin Lu
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote: > Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Marked as reviewed by jlu (Committer). - PR Review: https://git.openjdk.org/jdk/pull/19070#pullrequestrevi

Re: RFR: 8331582: Incorrect default Console provider comment

2024-05-02 Thread Jan Lahoda
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote: > Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Looks good to me, thanks! - Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/

Re: RFR: 8331582: Incorrect default Console provider comment

2024-05-02 Thread Joe Wang
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote: > Fixing a comment in `java.io.Console`, which was a leftover from the fix to > https://bugs.openjdk.org/browse/JDK-8308591 Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19070#pullrequestrev

RFR: 8331582: Incorrect default Console provider comment

2024-05-02 Thread Naoto Sato
Fixing a comment in `java.io.Console`, which was a leftover from the fix to https://bugs.openjdk.org/browse/JDK-8308591 - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/19070/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19070&range=00 Issu