Re: RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-14 Thread Johannes Kuhn
On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote: > Straightforward test update so it doesn't have to be trivially updated for > each JDK version. Marked as reviewed by jkuhn (Author). - PR Review: https://git.openjdk.org/jdk/pull/18769#pullrequestreview-1999661348

Re: RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-13 Thread Mandy Chung
On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote: > Straightforward test update so it doesn't have to be trivially updated for > each JDK version. LGTM. Thanks for fixing this. - Marked as reviewed by mchung (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18769#pullrequ

Re: RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-13 Thread Joe Darcy
On Sat, 13 Apr 2024 00:40:45 GMT, Chen Liang wrote: > Thanks for this fix. I recall that I had to add this flag because otherwise > compileSources fails when `@enablePreview` is there. If we can drop the > preview flag, that would be the best. Thanks; I did a quick experiment and the test stil

Re: RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-12 Thread Chen Liang
On Fri, 12 Apr 2024 23:55:01 GMT, Joe Darcy wrote: > Straightforward test update so it doesn't have to be trivially updated for > each JDK version. Thanks for this fix. I recall that I had to add this flag because otherwise compileSources fails when `@enablePreview` is there. If we can drop th

RFR: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic

2024-04-12 Thread Joe Darcy
Straightforward test update so it doesn't have to be trivially updated for each JDK version. - Commit messages: - JDK-8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic Changes: https://git.openjdk.org/jdk/pull/18769/files Webrev: https://webrevs.openjdk