Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-04-01 Thread Jie Fu
On Mon, 1 Apr 2024 16:55:45 GMT, Naoto Sato wrote: >> Hi all, >> >> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing >> machines. >> I'm not an expert in this area and just guess it can be fixed like this. >> Please review it. >> >> Thanks. >> Best regards, >> Jie > >

Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-04-01 Thread Naoto Sato
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote: > Hi all, > > java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing > machines. > I'm not an expert in this area and just guess it can be fixed like this. > Please review it. > > Thanks. > Best regards, > Jie LGTM. Thanks fo

Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-04-01 Thread Jie Fu
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote: > Hi all, > > java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing > machines. > I'm not an expert in this area and just guess it can be fixed like this. > Please review it. > > Thanks. > Best regards, > Jie May I get one m

Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-03-31 Thread Jie Fu
On Sat, 30 Mar 2024 22:00:26 GMT, Justin Lu wrote: > This is indeed the correct solution to ensure that the DecimalFormat, > (specifically, the underlying DecimalFormatSymbols) has the same locale as > the MessageFormat subformat. Thanks @justin-curtis-lu for the review. - PR Com

Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-03-30 Thread Justin Lu
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote: > Hi all, > > java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing > machines. > I'm not an expert in this area and just guess it can be fixed like this. > Please review it. > > Thanks. > Best regards, > Jie Hi Jie, This i

RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-03-29 Thread Jie Fu
Hi all, java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing machines. I'm not an expert in this area and just guess it can be fixed like this. Please review it. Thanks. Best regards, Jie - Commit messages: - 8329354: java/text/Format/MessageFormat/CompactSub