Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-13 Thread Magnus Ihse Bursie
On Wed, 13 Mar 2024 09:50:20 GMT, Joachim Kern wrote: > e.g. We should change the HOTSPOT_TOOLCHAIN_TYPE=xlc to aix, because it is > not toolchain, but OS related. As a consequence the globalDefinitions_xlc.hpp > will become globalDefinitions_aix.hpp No, it's not that simple. First, the `globa

Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-13 Thread Joachim Kern
On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >>

Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-13 Thread Magnus Ihse Bursie
On Wed, 13 Mar 2024 08:50:10 GMT, Matthias Baesken wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING >> - We need CC_VERSION_OUTPUT before we can check it > >

Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-13 Thread Matthias Baesken
On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >>

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-13 Thread Matthias Baesken
On Tue, 12 Mar 2024 16:02:41 GMT, Matthias Baesken wrote: > > Please re-test. > > Hi Magnus, thanks for the adjustments. I reenabled your patch in our > build/test queue . Builds and test results on AIX (product and fastdebug) are fine with the latest version of the PR . - PR Co

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Matthias Baesken
On Tue, 12 Mar 2024 15:24:21 GMT, Magnus Ihse Bursie wrote: > Please re-test. Hi Magnus, thanks for the adjustments. I reenabled your patch in our build/test queue . - PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1992009593

Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-12 Thread Magnus Ihse Bursie
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building > the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect > clang by another name, and it uses the clang toolchain in the JDK build. Thus > the old xlc toolchain is no longer supported, and should be r

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Mon, 11 Mar 2024 12:27:08 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/toolchain.m4 line 940: > >> 938: if test "x$OPENJDK_TARGET_OS" =

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Mon, 11 Mar 2024 12:44:55 GMT, Matthias Baesken wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > With this change added, currently configure fails > > > checking for ibm-l

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Tue, 12 Mar 2024 15:15:27 GMT, Magnus Ihse Bursie wrote: >> make/autoconf/toolchain.m4 line 409: >> >>> 407: #Target: powerpc-ibm-aix7.2.0.0 >>> 408: #Thread model: posix >>> 409: #InstalledDir: /opt/IBM/openxlC/17.1.0/bin >> >> Please correct: >> IBM Open XL C/C++ fo

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Mon, 11 Mar 2024 09:14:27 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/toolchain.m4 line 409: > >> 407: #Target: powerpc-ibm-aix7.

Re: RFR: 8327701: Remove the xlc toolchain [v3]

2024-03-12 Thread Magnus Ihse Bursie
On Mon, 11 Mar 2024 13:45:46 GMT, Joachim Kern wrote: >> OK this was a flaw in my introduction of clang toolchain for AIX. The >> intention was to keep the xlc options in form of their clang counterparts. I >> will try with a corrected version for clang on AIX and will come back to you. > > OK,

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Tue, 12 Mar 2024 15:07:15 GMT, Magnus Ihse Bursie wrote: >>> Is Open XL C/C++ considered a compiler or more akin to a development >>> environment like Xcode is for macOS? Depending on which, we could just say >>> clang is the compiler for AIX without needing to say that Open XL is >>> treat

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Tue, 12 Mar 2024 15:04:56 GMT, Magnus Ihse Bursie wrote: >> Is Open XL C/C++ considered a compiler or more akin to a development >> environment like Xcode is for macOS? Depending on which, we could just say >> clang is the compiler for AIX without needing to say that Open XL is treated >> l

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-12 Thread Magnus Ihse Bursie
On Mon, 11 Mar 2024 09:30:20 GMT, Julian Waters wrote: > Is Open XL C/C++ considered a compiler or more akin to a development > environment like Xcode is for macOS? Depending on which, we could just say > clang is the compiler for AIX without needing to say that Open XL is treated > like clang

Re: RFR: 8327701: Remove the xlc toolchain [v3]

2024-03-12 Thread Magnus Ihse Bursie
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building > the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect > clang by another name, and it uses the clang toolchain in the JDK build. Thus > the old xlc toolchain is no longer supported, and should be r

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Mon, 11 Mar 2024 08:59:03 GMT, Joachim Kern wrote: >> make/autoconf/flags-cflags.m4 line 687: >> >>> 685: PICFLAG="-fPIC" >>> 686: PIEFLAG="-fPIE" >>> 687: elif test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" >>> = xaix; then >> >> Just a remark: This code has never

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Matthias Baesken
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Julian Waters
On Mon, 11 Mar 2024 08:38:53 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > doc/building.html line 679: > >> 677: IBM Open XL C/C++ >> 678: The minimum accep

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:31:18 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/flags-cflags.m4 line 687: > >> 685: PICFLAG="-fPIC" >> 686

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Matthias Baesken
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Erik Joelsson
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Julian Waters
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Magnus Ihse Bursie
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building > the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect > clang by another name, and it uses the clang toolchain in the JDK build. Thus > the old xlc toolchain is no longer supported, and should be r

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 15:44:48 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 15:41:16 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/toolchain.m4 line 444: > >> 442: COMPILER_NAME=$2 >> 443:

Re: RFR: 8327701: Remove the xlc toolchain

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie wrote: > As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building > the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect > clang by another name, and it uses the clang toolchain in the JDK build. Thus >

RFR: 8327701: Remove the xlc toolchain

2024-03-08 Thread Magnus Ihse Bursie
As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

Re: RFR: 8327701: Remove the xlc toolchain

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie wrote: > As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building > the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect > clang by another name, and it uses the clang toolchain in the JDK build. Thus >