Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-22 Thread Hamlin Li
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-21 Thread David Holmes
On Sat, 19 Oct 2024 06:33:01 GMT, ExE Boss wrote: >> `test/hotspot/jtreg/runtime/AccessCheckSuper.java` is one test that fails >> the super class access check. @lfoltan may know whether there are more >> tests besides this one. > > This code was necessary back when this was the `sun.reflect` p

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-21 Thread David Holmes
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-19 Thread ExE Boss
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-19 Thread ExE Boss
On Fri, 18 Oct 2024 17:18:05 GMT, Mandy Chung wrote: >>> // If the loader is not the boot loader then throw an exception if its >>> // superclass is in package jdk.internal.reflect >> >> This should not be needed. `jdk.internal.reflect` is a non-exported >> package in `java.base` module. If

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-18 Thread Mandy Chung
On Fri, 18 Oct 2024 16:54:59 GMT, Mandy Chung wrote: >> Oh that's a good find. Maybe we should write a test for this, if as I >> assume there isn't one already. >> Edit: not with this RFE, just in general. > >> // If the loader is not the boot loader then throw an exception if its >> // supercl

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-18 Thread Mandy Chung
On Fri, 18 Oct 2024 16:17:12 GMT, Coleen Phillimore wrote: >> src/hotspot/share/classfile/classFileParser.cpp line 4098: >> >>> 4096: } >>> 4097: } >>> 4098: >> >> This code should not be removed. The spec for this code should now be: >> >> // If the loader is not the boot loader

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-18 Thread Mandy Chung
On Fri, 18 Oct 2024 03:54:40 GMT, John R Rose wrote: > Happily, that day has come. Yes, feeling happy!I have been waiting to get rid of this last piece! - PR Comment: https://git.openjdk.org/jdk/pull/21571#issuecomment-2422885117

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-18 Thread Coleen Phillimore
On Fri, 18 Oct 2024 02:25:16 GMT, David Holmes wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused classes > > src/hotspot/share/classfile/classFileParser.cpp line 4098: > >> 4096: } >> 4097: }

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-18 Thread Alan Bateman
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-17 Thread John R Rose
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-17 Thread David Holmes
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-17 Thread Chen Liang
On Thu, 17 Oct 2024 22:44:05 GMT, Mandy Chung wrote: >> The old core reflection implementation generates dynamic classes that are >> special cases in the VM to bypass bytecode verification to workaround >> various issues [1] [2] [3]. >> >> The old core reflection implementation was [removed in

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection

2024-10-17 Thread Mandy Chung
On Thu, 17 Oct 2024 20:45:53 GMT, Mandy Chung wrote: > The old core reflection implementation generates dynamic classes that are > special cases in the VM to bypass bytecode verification to workaround various > issues [1] [2] [3]. > > The old core reflection implementation was [removed in JDK

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

2024-10-17 Thread Mandy Chung
> The old core reflection implementation generates dynamic classes that are > special cases in the VM to bypass bytecode verification to workaround various > issues [1] [2] [3]. > > The old core reflection implementation was [removed in JDK > 22](https://bugs.openjdk.org/browse/JDK-8305104).

Re: RFR: 8327624: Remove VM implementation that bypass verification for core reflection

2024-10-17 Thread Chen Liang
On Thu, 17 Oct 2024 20:45:53 GMT, Mandy Chung wrote: > The old core reflection implementation generates dynamic classes that are > special cases in the VM to bypass bytecode verification to workaround various > issues [1] [2] [3]. > > The old core reflection implementation was [removed in JDK

RFR: 8327624: Remove VM implementation that bypass verification for core reflection

2024-10-17 Thread Mandy Chung
The old core reflection implementation generates dynamic classes that are special cases in the VM to bypass bytecode verification to workaround various issues [1] [2] [3] uncovered over time. The old core reflection implementation was [removed in JDK 22](https://bugs.openjdk.org/browse/JDK-8305