On Thu, 7 Mar 2024 22:59:38 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> sinc
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> loaded, but not the period after the artifact is compl
On Thu, 7 Mar 2024 21:00:01 GMT, Ioi Lam wrote:
>> A few clean ups:
>>
>> 1. Rename functions like "`s_loading_full_module_graph()` to
>> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
>> might be interpreted as to cover only the period where the artifact is being
>
On Thu, 7 Mar 2024 06:50:04 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more alignment
>
> src/hotspot/share/cds/cdsConfig.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2024, Oracle and/or its aff
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> loaded, but not the period after the artifact is compl
On Wed, 6 Mar 2024 23:36:09 GMT, Ioi Lam wrote:
>> A few clean ups:
>>
>> 1. Rename functions like "`s_loading_full_module_graph()` to
>> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
>> might be interpreted as to cover only the period where the artifact is being
>
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> loaded, but not the period after the artifact is compl
On Wed, 6 Mar 2024 18:42:01 GMT, Matias Saavedra Silva
wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed alignments
>
> src/hotspot/share/cds/cdsConfig.hpp line 72:
>
>> 70: static void enable_dumping_dynamic_a
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> loaded, but not the period after the artifact is compl
On Sat, 2 Mar 2024 01:18:06 GMT, Ioi Lam wrote:
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> load
On Wed, 6 Mar 2024 01:58:26 GMT, Ioi Lam wrote:
>> I meant the following. Just the last line #94 needs to be changed - shift
>> one space to the left after `bool`.
>>
>> static bool is_dumping_heap()
>> NOT_CDS_JAVA_HEAP_RETURN_(false);
>> static void stop_dumping_
On Tue, 5 Mar 2024 23:49:02 GMT, Calvin Cheung wrote:
>> Do you mean aligning like this:
>>
>>
>> static bool is_dumping_heap()
>> NOT_CDS_JAVA_HEAP_RETURN_(false);
>> static void stop_dumping_full_module_graph(const char* reason = nullptr)
>> NOT_CDS_JAVA_HE
On Tue, 5 Mar 2024 23:38:21 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/cdsConfig.hpp line 94:
>>
>>> 92: static bool is_dumping_full_module_graph() { return
>>> CDS_ONLY(_is_dumping_full_module_graph) NOT_CDS(false); }
>>> 93: static void stop_using_full_module_graph(con
On Tue, 5 Mar 2024 20:39:10 GMT, Calvin Cheung wrote:
>> A few clean ups:
>>
>> 1. Rename functions like "`s_loading_full_module_graph()` to
>> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
>> might be interpreted as to cover only the period where the artifact is be
On Sat, 2 Mar 2024 01:18:06 GMT, Ioi Lam wrote:
> A few clean ups:
>
> 1. Rename functions like "`s_loading_full_module_graph()` to
> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it
> might be interpreted as to cover only the period where the artifact is being
> load
A few clean ups:
1. Rename functions like "`s_loading_full_module_graph()` to
`is_using_full_module_graph()`. The meaning of "loading" is not clear: it might
be interpreted as to cover only the period where the artifact is being loaded,
but not the period after the artifact is completely loaded
16 matches
Mail list logo
