Re: [jdk22] RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-13 Thread Roger Riggs
On Tue, 13 Feb 2024 15:57:31 GMT, Roger Riggs wrote: > 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 The backport was intended to be for jdk22u - PR Comment: https://git.openjdk.org/jdk22/pull/110#issuecomment-1941927141

Re: [jdk22] RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 16:09:04 GMT, Alan Bateman wrote: >> 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 > > This is for jdk22u, not jdk22 @AlanBateman You might want to unapprove this PR (go to "Files" and submit a review with "Request Changes") UPDATE: I see you alread

Re: [jdk22] RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-13 Thread Alan Bateman
On Tue, 13 Feb 2024 15:57:31 GMT, Roger Riggs wrote: > 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 Marked as reviewed by alanb (Reviewer). This is for jdk22u, not jdk22 This is for jdk22u, not jdk22 - PR Review: https://git.openjdk.org/jdk22/pull/110#pu

Re: [jdk22] RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-13 Thread Kevin Rushforth
On Tue, 13 Feb 2024 15:57:31 GMT, Roger Riggs wrote: > 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 @RogerRiggs Since this is deferred out of JDK 22, you need to close this PR and open a new one against jdk22u. - PR Comment: https://git.openjdk.org/jdk22/

[jdk22] RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-13 Thread Roger Riggs
8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 - Commit messages: - Backport 13d9e8ff38536287b82c54bb63bd2d20f65615dc Changes: https://git.openjdk.org/jdk22/pull/110/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=110&range=00 Issue: https://bugs.

Re: RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 [v2]

2024-02-13 Thread Claes Redestad
On Tue, 13 Feb 2024 12:47:26 GMT, Roger Riggs wrote: >> Correct the result string coder of a string encoded using a CharsetDecoder >> with multi-byte encoded input. >> Added tests for UTF16 strings and a regression test. > > Roger Riggs has updated the pull request incrementally with one additio

Re: RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 [v2]

2024-02-13 Thread Alan Bateman
On Tue, 13 Feb 2024 12:47:26 GMT, Roger Riggs wrote: >> Correct the result string coder of a string encoded using a CharsetDecoder >> with multi-byte encoded input. >> Added tests for UTF16 strings and a regression test. > > Roger Riggs has updated the pull request incrementally with one additio

Re: RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 [v2]

2024-02-13 Thread Roger Riggs
> Correct the result string coder of a string encoded using a CharsetDecoder > with multi-byte encoded input. > Added tests for UTF16 strings and a regression test. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Test Files.readString

Re: RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 [v2]

2024-02-13 Thread Roger Riggs
On Tue, 13 Feb 2024 07:21:01 GMT, Alan Bateman wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test Files.readString with multiple charsets >> Cleanup regression test to match style of other tests > > test/jdk/jav

Re: RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-12 Thread Alan Bateman
On Mon, 12 Feb 2024 21:29:02 GMT, Roger Riggs wrote: > Correct the result string coder of a string encoded using a CharsetDecoder > with multi-byte encoded input. > Added tests for UTF16 strings and a regression test. test/jdk/java/nio/file/Files/ReadWriteString.java line 322: > 320: }

RFR: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906

2024-02-12 Thread Roger Riggs
Correct the result string coder of a string encoded using a CharsetDecoder with multi-byte encoded input. Added tests for UTF16 strings and a regression test. - Commit messages: - 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906 Changes: https://git.openjdk.or