On Tue, 16 Jan 2024 09:11:01 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Tue, 16 Jan 2024 18:47:43 GMT, Joe Darcy wrote:
> We can and have run retroactive CSRs in cases like this before; I recommend
> we do one now.
Yes although the issue will be mute once JDK-8323659 is integrated into jdk22.
-
PR Comment: https://git.openjdk.org/jdk/pull/17393#iss
On Mon, 15 Jan 2024 09:49:53 GMT, Alan Bateman wrote:
> > With my CSR hat on, JDK-8301341 should never have made the changes it did
> > without going through a CSR request. We have been bitten by this kind of
> > problem many times. Unless a public method is specified to utilise another
> > pu
On Tue, 16 Jan 2024 12:23:43 GMT, Chris Hegarty wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
Hi all,
This pull request contains a backport of commit
[ee4d9aa4](https://github.com/openjdk/jdk/commit/ee4d9aa4c11c47e7cf15f2742919ac20311f9ea7)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Chris Hegarty on 16 Jan 2024 and
was re
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight addi
On Mon, 15 Jan 2024 09:49:53 GMT, Alan Bateman wrote:
>> With my CSR hat on, JDK-8301341 should never have made the changes it did
>> without going through a CSR request. We have been bitten by this kind of
>> problem many times. Unless a public method is specified to utilise another
>> public
On Mon, 15 Jan 2024 17:59:38 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Mon, 15 Jan 2024 17:59:38 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains seven addi
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Mon, 15 Jan 2024 12:34:57 GMT, Doug Lea wrote:
> Sorry for needlessly calling overridable versions in these two cases. I
> should have caught that.
No problem, easy to overlook. I assume you are ok with the changes? If so,
could I please ask you to add your review. Otherwise, is there anoth
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five addit
On Mon, 15 Jan 2024 09:49:39 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/
On Mon, 15 Jan 2024 01:55:12 GMT, David Holmes wrote:
> With my CSR hat on, JDK-8301341 should never have made the changes it did
> without going through a CSR request. We have been bitten by this kind of
> problem many times. Unless a public method is specified to utilise another
> public met
On Mon, 15 Jan 2024 07:31:13 GMT, Andrey Turbanov wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> timed offer
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 1162:
>
>> 1160:
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
Co-authored-by: An
On Fri, 12 Jan 2024 15:06:01 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> timed offer
src/java.base/share/class
On Fri, 12 Jan 2024 15:06:01 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> timed offer
With my CSR hat on, JDK-8
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
timed offer
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17393/files
- new: https
On Fri, 12 Jan 2024 15:02:59 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> timed offer
src/java.base/share/class
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
add test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17393/files
- new: https://
On Fri, 12 Jan 2024 10:38:40 GMT, Chris Hegarty wrote:
> Update LinkedTransferQueue add and put methods to not call overridable.
FTR - I agree that it's kinda annoying to be proposing this change and it is
true that the consuming user code is making an assumption, but the impact of
this is sig
On Fri, 12 Jan 2024 12:10:46 GMT, Chris Hegarty wrote:
>>> this PR is against mainline, but the issue's Fix Version/s is 22.
>>
>> I updated the fix version in JIRA, and followed the process as outlined in
>> https://mail.openjdk.org/pipermail/jdk-dev/2023-December/008560.html
>
>> @ChrisHegart
On Fri, 12 Jan 2024 11:22:13 GMT, Chris Hegarty wrote:
>>> A process-related comment: this PR is against mainline, but the issue's Fix
>>> Version/s is 22. This will create a bit of a mess if integrated.
>>
>> Thanks for the reminder Pavel. If accepted, then the change will be
>> applicable t
On Fri, 12 Jan 2024 11:22:13 GMT, Chris Hegarty wrote:
>>> A process-related comment: this PR is against mainline, but the issue's Fix
>>> Version/s is 22. This will create a bit of a mess if integrated.
>>
>> Thanks for the reminder Pavel. If accepted, then the change will be
>> applicable t
On Fri, 12 Jan 2024 11:11:51 GMT, Chris Hegarty wrote:
> this PR is against mainline, but the issue's Fix Version/s is 22.
I updated the fix version in JIRA, and followed the process as outlined in
https://mail.openjdk.org/pipermail/jdk-dev/2023-December/008560.html
-
PR Comment:
On Fri, 12 Jan 2024 11:07:17 GMT, Pavel Rappo wrote:
> A process-related comment: this PR is against mainline, but the issue's Fix
> Version/s is 22. This will create a bit of a mess if integrated.
Thanks for the reminder Pavel. If accepted, then the change will be applicable
to 23, 22, and 2
On Fri, 12 Jan 2024 10:38:40 GMT, Chris Hegarty wrote:
> Update LinkedTransferQueue add and put methods to not call overridable.
A process-related comment: this PR is against mainline, but the issue's Fix
Version/s is 22. This will create a bit of a mess if integrated.
-
PR Commen
On Fri, 12 Jan 2024 11:03:02 GMT, Alan Bateman wrote:
> This feels more like a hazard when extending to override behavior.
Yeah, this is certainly a potential issue with any subclass-able class. I
remember seeing similar before in other areas too.
> I think it would be useful to provide a sum
On Fri, 12 Jan 2024 10:38:40 GMT, Chris Hegarty wrote:
> Update LinkedTransferQueue add and put methods to not call overridable.
This feels more like a hazard when extending to override behavior. I think it
would be useful to provide a summary on what the override wants to do, maybe
there are
Update LinkedTransferQueue add and put methods to not call overridable.
-
Commit messages:
- Update LinkedTransferQueue add and put methods to not call overridable offer
Changes: https://git.openjdk.org/jdk/pull/17393/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17393&ran
33 matches
Mail list logo
