Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-12 Thread Claes Redestad
On Thu, 11 Jan 2024 17:49:42 GMT, Erik Joelsson wrote: > Fair enough. This isn't worse than the current CWD. The test image dir and > the support output dir have no guaranteed relationship relative to each > other, so we can't rely any relative path between them. Thanks! Perhaps we can improve

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-11 Thread Erik Joelsson
On Thu, 11 Jan 2024 14:17:39 GMT, Erik Joelsson wrote: >> In principle, I think tests should be executed from their corresponding >> test-support directory. (I think there is some JBS issue for this that's >> been around for some while.) The rationale is that this is a good directory >> for an

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-11 Thread Claes Redestad
On Thu, 11 Jan 2024 14:17:39 GMT, Erik Joelsson wrote: >> In principle, I think tests should be executed from their corresponding >> test-support directory. (I think there is some JBS issue for this that's >> been around for some while.) The rationale is that this is a good directory >> for an

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-11 Thread Erik Joelsson
On Thu, 11 Jan 2024 11:23:55 GMT, Magnus Ihse Bursie wrote: > In principle, I think tests should be executed from their corresponding > test-support directory. (I think there is some JBS issue for this that's been > around for some while.) The rationale is that this is a good directory for > a

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-11 Thread Magnus Ihse Bursie
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote: > JMH microbenchmarks may have dependencies on artifacts in the test image > outside of the benchmarks.jar. This includes native libraries (built into > `$TEST_IMAGE/micro/native`) and may soon include other test libraries like > wb.jar (

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-10 Thread Erik Joelsson
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote: > JMH microbenchmarks may have dependencies on artifacts in the test image > outside of the benchmarks.jar. This includes native libraries (built into > `$TEST_IMAGE/micro/native`) and may soon include other test libraries like > wb.jar (

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-10 Thread Jorn Vernee
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote: > JMH microbenchmarks may have dependencies on artifacts in the test image > outside of the benchmarks.jar. This includes native libraries (built into > `$TEST_IMAGE/micro/native`) and may soon include other test libraries like > wb.jar (

RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-10 Thread Claes Redestad
JMH microbenchmarks may have dependencies on artifacts in the test image outside of the benchmarks.jar. This includes native libraries (built into `$TEST_IMAGE/micro/native`) and may soon include other test libraries like wb.jar (built into `$TEST_IMAGE/lib-test/`) By moving execution to the te

Re: RFR: 8323529: Relativize test image dependencies in microbenchmarks

2024-01-10 Thread Maurizio Cimadamore
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote: > JMH microbenchmarks may have dependencies on artifacts in the test image > outside of the benchmarks.jar. This includes native libraries (built into > `$TEST_IMAGE/micro/native`) and may soon include other test libraries like > wb.jar (