On Wed, 20 Dec 2023 08:07:38 GMT, Alan Bateman wrote:
>> …g exception
>>
>> After leaving the method by throwing an exception the data can not be
>> cleaned any more.
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 122:
>
>> 120: ioe.addSupp
On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier wrote:
> …g exception
>
> After leaving the method by throwing an exception the data can not be cleaned
> any more.
src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 122:
> 120: ioe.addSuppresse
On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier wrote:
> …g exception
>
> After leaving the method by throwing an exception the data can not be cleaned
> any more.
Thanks for the reviews!
SAPs nigthly testing passed for this change.
Sorry, I saw the java.uti. comment too late :(
---
On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier wrote:
> …g exception
>
> After leaving the method by throwing an exception the data can not be cleaned
> any more.
LGTM. Please remove the redundant package name before push.
src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java l
On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier wrote:
> …g exception
>
> After leaving the method by throwing an exception the data can not be cleaned
> any more.
Seems reasonable.
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17156#
On Tue, 19 Dec 2023 12:47:53 GMT, Goetz Lindenmaier wrote:
> …g exception
>
> After leaving the method by throwing an exception the data can not be cleaned
> any more.
Marked as reviewed by mbaesken (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17156#pullrequestreview
