On Fri, 30 Aug 2024 13:02:21 GMT, Lance Andersen wrote:
> > If we are retrofitting the APIs docs then I think treat "GZIP" as a file
> > format. It may require adding overrides so there is a place to document the
> > behavior when reading an entry roll over into the next stream.
>
> Perhaps, a
On Fri, 30 Aug 2024 11:44:09 GMT, Alan Bateman wrote:
> > The gnu.org docs cover this(concatenating gzip files) as part of its
> > [advanced usage of
> > gzip](https://github.com/openjdk/jdk/pull/20787#issuecomment-2320873616),
> > so I don'r think we need to do any more archeology
>
> Okay,
On Fri, 30 Aug 2024 11:18:41 GMT, Lance Andersen wrote:
> The gnu.org docs cover this(concatenating gzip files) as part of its
> [advanced usage of
> gzip](https://github.com/openjdk/jdk/pull/20787#issuecomment-2320873616), so
> I don'r think we need to do any more archeology
Okay, but just v
On Fri, 30 Aug 2024 11:18:41 GMT, Lance Andersen wrote:
>> I wonder if we can dig up the discussion on JDK-4691425. I can't find the
>> CSR (or "CCC" at the time) that would have captured the reasoning for
>> supporting this.
>
>> I wonder if we can dig up the discussion on JDK-4691425. I can't
On Fri, 30 Aug 2024 11:07:40 GMT, Alan Bateman wrote:
> I wonder if we can dig up the discussion on JDK-4691425. I can't find the CSR
> (or "CCC" at the time) that would have captured the reasoning for supporting
> this.
The gnu.org docs cover this(concatenating gzip files) as part of its [ad
On Fri, 30 Aug 2024 10:50:37 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR with picks up on the excellent work done by
>> @archiecobbs in #18385
>>
>> The proposed changes aim to solve two issues with the current
>> `java.util.zip.GZIPInputStream`:
>>
>> * The class parses multiple con
> Please review this PR with picks up on the excellent work done by
> @archiecobbs in #18385
>
> The proposed changes aim to solve two issues with the current
> `java.util.zip.GZIPInputStream`:
>
> * The class parses multiple concatenated GZIP files as a single stream. This
> behavior is not
Please review this PR with picks up on the excellent work done by @archiecobbs
in #18385
The proposed changes aim to solve two issues with the current
`java.util.zip.GZIPInputStream`:
* The class parses multiple concatenated GZIP files as a single stream. This
behavior is not documented in th
On Fri, 30 Aug 2024 07:27:11 GMT, Eirik Bjørsnøs wrote:
> Please review this PR with picks up on the excellent work done by
> @archiecobbs in #18385
>
> The proposed changes aim to solve two issues with the current
> `java.util.zip.GZIPInputStream`:
>
> * The class parses multiple concatenat
On Wed, 28 Aug 2024 21:56:50 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Wed, 28 Aug 2024 21:56:50 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Wed, 28 Aug 2024 21:56:50 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Wed, 28 Aug 2024 21:56:50 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Wed, 28 Aug 2024 19:56:04 GMT, Lance Andersen wrote:
>> Sounds good. How would you like to do that?
>>
>> E.g. we could just remove the words "In particular, some GZIP compression
>> tools function by partitioning the input, compressing each partition
>> separately, and then concatenating t
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
On Wed, 28 Aug 2024 18:08:43 GMT, Archie Cobbs wrote:
> Sounds good. How would you like to do that?
>
> E.g. we could just remove the words "In particular, some GZIP compression
> tools function by partitioning the input, compressing each partition
> separately, and then concatenating the resu
On Wed, 28 Aug 2024 17:50:36 GMT, Lance Andersen wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert all functional changes, leaving only tests & Javadoc.
>
> src/java.base/share/classes/java/util/zip/GZIPInputS
On Sun, 11 Aug 2024 18:58:05 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Wed, 31 Jul 2024 15:51:48 GMT, Lance Andersen wrote:
>> Another (more conservative) possibility is to preserve both 1 ("Trailing
>> garbage is ignored") and 3 ("Concatenated streams are automatically
>> decoded") in the default configuration.
>>
>> Then basically all we would be changing is
On Wed, 31 Jul 2024 15:51:48 GMT, Lance Andersen wrote:
>> Another (more conservative) possibility is to preserve both 1 ("Trailing
>> garbage is ignored") and 3 ("Concatenated streams are automatically
>> decoded") in the default configuration.
>>
>> Then basically all we would be changing is
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Fri, 2 Aug 2024 13:12:00 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor to eliminate "lenient" mode (still failng test: GZIPInZip.java).
>> - Add GZIP input test for various gzip(1
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Tue, 30 Jul 2024 19:00:13 GMT, Archie Cobbs wrote:
> Another (more conservative) possibility is to preserve both 1 ("Trailing
> garbage is ignored") and 3 ("Concatenated streams are automatically decoded")
> in the default configuration.
>
> Then basically all we would be changing is no lon
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Tue, 30 Jul 2024 17:35:33 GMT, Lance Andersen wrote:
> Based on the above, I am reluctant to change the current behavior given it
> appears to have been modeled after gzip/gunzip as well as WinZip.
That's a reasonable conclusion... and I have no problem with preserving the
existing behavior
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Mon, 29 Jul 2024 14:27:28 GMT, Lance Andersen wrote:
> ... we really need more datapoint to better understand the risks/benefits in
> order to make an informed decision.
Agreed.
Here's some what I've come up with after a little bit of research:
First, we shouldn't confuse GZIP with ZIP fil
On Mon, 29 Jul 2024 13:52:57 GMT, Archie Cobbs wrote:
> > So where does that leave us:
> > Keep the code as is and document the current behavior
> > Continue to add additional test coverage for the current API
> > We probably do not need a new constructor given it probably adds no new
> > additi
On Mon, 29 Jul 2024 13:06:24 GMT, Lance Andersen wrote:
> So where does that leave us:
>
>Keep the code as is and document the current behavior
>Continue to add additional test coverage for the current API
>We probably do not need a new constructor given it probably adds no new
> ad
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
On Fri, 26 Jul 2024 16:46:28 GMT, Archie Cobbs wrote:
> With this new proposed change we will throw an IOException (unlike
> previously). I think that's fine and in fact the correct thing to do.
I've run into a problem.
With this change, `GZIPInZip.java` fails; the test is annotated like this:
On Fri, 26 Jul 2024 16:12:11 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8322256
>> - Wording tweak.
>> - Change concatenation poli
On Wed, 24 Jul 2024 14:57:05 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Fri, 26 Jul 2024 13:36:43 GMT, Lance Andersen wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8322256
>> - Wording tweak.
>> - Change concatenation po
On Wed, 24 Jul 2024 14:57:05 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
On Mon, 22 Jul 2024 18:08:52 GMT, Eirik Bjørsnøs wrote:
>>> The term "extra" here feels somewhat open to interpretation. Specifically,
>>> "extra" sounds like something that is out of the ordinary, but not uncommon
>>> or wrong. It could be used when describing an optional feature in a format
On Fri, 19 Jul 2024 23:16:07 GMT, Archie Cobbs wrote:
>> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 143:
>>
>>> 141: * @param allowConcatenation true to allow multiple concatenated
>>> compressed data streams,
>>> 142: * or false to e
On Fri, 19 Jul 2024 09:56:46 GMT, Eirik Bjørsnøs wrote:
> The term "extra" here feels somewhat open to interpretation. Specifically,
> "extra" sounds like something that is out of the ordinary, but not uncommon
> or wrong. It could be used when describing an optional feature in a format
> spec
On Mon, 15 Jul 2024 10:01:47 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Bump @since from 23 to 24.
>> - Merge branch 'master' into JDK-8322256
>> - Relabel "trai
On Thu, 6 Jun 2024 17:03:57 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>>
On Thu, 6 Jun 2024 17:03:57 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>>
On Mon, 15 Jul 2024 13:12:41 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 153:
>>
>>> 151: */
>>> 152: public GZIPInputStream(InputStream in, int size,
>>> 153: boolean allowConcatenation, boolean ignoreExtraBytes)
>>> thro
On Mon, 15 Jul 2024 10:06:20 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Bump @since from 23 to 24.
>> - Merge branch 'master' into JDK-8322256
>> - Relabel "trai
On Thu, 6 Jun 2024 17:03:57 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>>
On Thu, 6 Jun 2024 17:03:57 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>>
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
`GZIPInputStream` supports reading data from multiple concatenated GZIP data
streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
order to do this, after a GZIP trailer frame is read, it attempts to read a
GZIP header frame and, if successful, proceeds onward to decompres
57 matches
Mail list logo
