Re: RFR: 8320788: The system properties page is missing some properties [v3]

2024-01-11 Thread Alan Bateman
On Tue, 9 Jan 2024 23:40:35 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase

Re: [jdk22] RFR: 8320788: The system properties page is missing some properties

2024-01-10 Thread Iris Clark
On Wed, 10 Jan 2024 20:56:14 GMT, Naoto Sato wrote: > Backporting the document only fix to jdk22 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/59#pullrequestreview-1814223539

Re: [jdk22] RFR: 8320788: The system properties page is missing some properties

2024-01-10 Thread Roger Riggs
On Wed, 10 Jan 2024 20:56:14 GMT, Naoto Sato wrote: > Backporting the document only fix to jdk22 Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/59#pullrequestreview-1814171861

[jdk22] RFR: 8320788: The system properties page is missing some properties

2024-01-10 Thread Naoto Sato
Backporting the document only fix to jdk22 - Commit messages: - Backport 3bd9042054116365323912ed5867b70936fe85c4 Changes: https://git.openjdk.org/jdk22/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320788

Re: RFR: 8320788: The system properties page is missing some properties [v3]

2024-01-10 Thread Naoto Sato
On Tue, 9 Jan 2024 23:40:35 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase

Re: RFR: 8320788: The system properties page is missing some properties [v3]

2024-01-09 Thread Naoto Sato
> Adding an explanation of the locale-related system properties in the > `System.getProperties()` method. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge branch

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Naoto Sato
On Tue, 9 Jan 2024 20:06:10 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/lang/System.java line 819: >> >>> 817: * >>> 818: * Additional locale-related system properties defined by the >>> 819: * {@link Locale##default_locale Default Locale} section in the >>> {@co

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Joe Wang
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Brian Burkhalter
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Roger Riggs
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Roger Riggs
On Tue, 9 Jan 2024 20:01:28 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/lang/System.java line 819: > >> 817: * >> 818: * Add

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Iris Clark
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Joe Wang
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote: >> Adding an explanation of the locale-related system properties in the >> `System.getProperties()` method. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Naoto Sato
On Tue, 9 Jan 2024 19:02:39 GMT, Iris Clark wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/lang/System.java line 818: > >> 816: * {@link #getProper

Re: RFR: 8320788: The system properties page is missing some properties [v2]

2024-01-09 Thread Naoto Sato
> Adding an explanation of the locale-related system properties in the > `System.getProperties()` method. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflects review comments -

Re: RFR: 8320788: The system properties page is missing some properties

2024-01-09 Thread Iris Clark
On Tue, 9 Jan 2024 00:51:28 GMT, Naoto Sato wrote: > Adding an explanation of the locale-related system properties in the > `System.getProperties()` method. Corresponding CSR has also been drafted. src/java.base/share/classes/java/lang/System.java line 818: > 816: * {@link #getProperty(St

RFR: 8320788: The system properties page is missing some properties

2024-01-09 Thread Naoto Sato
Adding an explanation of the locale-related system properties in the `System.getProperties()` method. Corresponding CSR has alos been drafted. - Depends on: https://git.openjdk.org/jdk/pull/17065 Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/17317/fil