Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Eirik Bjørsnøs
On Wed, 31 Jan 2024 13:16:08 GMT, Eirik Bjørsnøs wrote: >> Thank you for the update. This test-only change looks OK to me. >> >> Hello Sundar @sundararajana, given your past work on this test, do you have >> any thoughts on this change? > >> Hello Sundar @sundararajana, given your past work on

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Athijegannathan Sundararajan
On Wed, 24 Jan 2024 06:50:36 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. >> The test is currently implemented using a mix of shell script and a Java >> main method. >> >> Reviewers may notice the following changes: >> >> - The she

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Jaikiran Pai
On Wed, 31 Jan 2024 14:02:13 GMT, Eirik Bjørsnøs wrote: > > Whoops, I just integrated after the approval from @sundararajana, seconds > before this comment. That's alright. > > What is the best action here, just have a rollback PR ready in case of > failures? Typically when such failures

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Jaikiran Pai
On Wed, 31 Jan 2024 13:16:08 GMT, Eirik Bjørsnøs wrote: >> Thank you for the update. This test-only change looks OK to me. >> >> Hello Sundar @sundararajana, given your past work on this test, do you have >> any thoughts on this change? > >> Hello Sundar @sundararajana, given your past work on

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-31 Thread Eirik Bjørsnøs
On Wed, 24 Jan 2024 07:08:11 GMT, Jaikiran Pai wrote: > Hello Sundar @sundararajana, given your past work on this test, do you have > any thoughts on this change? @jaikiran We have not heard back from @sundararajana in the last week. It would be nice to see this low-risk change integrated. I

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-23 Thread Jaikiran Pai
On Wed, 24 Jan 2024 06:50:36 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. >> The test is currently implemented using a mix of shell script and a Java >> main method. >> >> Reviewers may notice the following changes: >> >> - The she

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java

2024-01-23 Thread Eirik Bjørsnøs
On Wed, 24 Jan 2024 05:03:29 GMT, Jaikiran Pai wrote: > The only part that is unclear to me is the use of `@library > /javax/script/JDK_8196959`. Does the test fail if that isn't added? Thanks! I must have thought this was required to put the service definition file on the classpath. But it is

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java [v2]

2024-01-23 Thread Eirik Bjørsnøs
> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. > The test is currently implemented using a mix of shell script and a Java main > method. > > Reviewers may notice the following changes: > > - The shell script file `BadFactoryTest.sh` has been retired and jtreg tag

Re: RFR: 8320712: Rewrite BadFactoryTest in pure Java

2024-01-23 Thread Jaikiran Pai
On Mon, 27 Nov 2023 17:44:24 GMT, Eirik Bjørsnøs wrote: > Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. > The test is currently implemented using a mix of shell script and a Java main > method. > > Reviewers may notice the following changes: > > - The shell scri

RFR: 8320712: Rewrite BadFactoryTest in pure Java

2023-11-28 Thread Eirik Bjorsnos
Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit. The test is currently implemented using a mix of shell script and a Java main method. Reviewers may notice the following changes: - The shell script file `BadFactoryTest.sh` has been retired and jtreg tags moved over