Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Lance Andersen
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by lance

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Iris Clark
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by iris

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Justin Lu
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by jlu (

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Roger Riggs
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by rrigg

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Joe Wang
On Tue, 14 Nov 2023 19:32:57 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > abbreviated/full clarification Marked as reviewed by joehw

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: abbreviated/full clarification - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: http

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v4]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 18:14:45 GMT, Roger Riggs wrote: >> Thanks for the feedback, Joe. I think I would rather keep the description >> somewhat abstract, simply mentioning the formatted output is `SHORT` <= >> `MEDIUM` <= `LONG` <= `FULL` in length-wise. As it is noted in the previous >> sentenc

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v3]

2023-11-14 Thread Roger Riggs
On Tue, 14 Nov 2023 17:14:06 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/text/DateFormat.java line 120: >> >>> 118: * result; from {@link #SHORT} to {@link #MEDIUM} to {@link #LONG} to >>> {@link #FULL}. The exact result depends >>> 119: * on the locale, but generally: >>> 120:

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 17:43:54 GMT, Justin Lu wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/text/DateFormat.java line 122: > >> 120: * {@link #SHORT} is

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v3]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Further clarification - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: https://git.o

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Justin Lu
On Tue, 14 Nov 2023 17:16:59 GMT, Naoto Sato wrote: >> Correcting the explanation of the `DateFormat.SHORT` constant. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments src/java.base/share/classes/java/

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
On Tue, 14 Nov 2023 01:41:15 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/text/DateFormat.java line 120: > >> 118: * result; from {@lin

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat [v2]

2023-11-14 Thread Naoto Sato
> Correcting the explanation of the `DateFormat.SHORT` constant. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflects review comments - Changes: - all: https://git.openjdk.org/jdk/pull/16645/files - new: https://gi

Re: RFR: 8319986: Invalid/inconsistent description and example for DateFormat

2023-11-13 Thread Joe Wang
On Mon, 13 Nov 2023 23:35:11 GMT, Naoto Sato wrote: > Correcting the explanation of the `DateFormat.SHORT` constant. src/java.base/share/classes/java/text/DateFormat.java line 120: > 118: * result; from {@link #SHORT} to {@link #MEDIUM} to {@link #LONG} to > {@link #FULL}. The exact result de

RFR: 8319986: Invalid/inconsistent description and example for DateFormat

2023-11-13 Thread Naoto Sato
Correcting the explanation of the `DateFormat.SHORT` constant. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/16645/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319986 Stats: 1 l