Re: RFR: 8319324: FFM: Reformat javadocs [v13]

2023-11-09 Thread Maurizio Cimadamore
On Thu, 9 Nov 2023 14:21:57 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v13]

2023-11-09 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v12]

2023-11-09 Thread Maurizio Cimadamore
On Thu, 9 Nov 2023 13:07:24 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v12]

2023-11-09 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v11]

2023-11-09 Thread Maurizio Cimadamore
On Thu, 9 Nov 2023 12:31:16 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v11]

2023-11-09 Thread Maurizio Cimadamore
On Thu, 9 Nov 2023 12:31:16 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v11]

2023-11-09 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v10]

2023-11-09 Thread Per Minborg
On Wed, 8 Nov 2023 09:03:12 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v10]

2023-11-08 Thread Maurizio Cimadamore
On Wed, 8 Nov 2023 09:03:12 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v10]

2023-11-08 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v9]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 20:08:45 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v9]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v8]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 17:35:31 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v8]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 17:35:31 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v8]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v7]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v6]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v5]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v4]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v3]

2023-11-06 Thread Per Minborg
On Mon, 6 Nov 2023 11:41:23 GMT, Maurizio Cimadamore wrote: > You might also want to look into the MethodHandles XYZCoordinates combinators > (as they have also been added as part of FFM). And, also, > `ModuleLayer::Controller::enableNativeAccess`, > `Module::isNativeAccessEnabled` and `FileC

Re: RFR: 8319324: FFM: Reformat javadocs [v3]

2023-11-06 Thread Per Minborg
On Mon, 6 Nov 2023 13:27:40 GMT, Jorn Vernee wrote: > FWIW, I've been sticking to a soft 120 character limit per line when writing > javadoc. Why should we use 90 columns specifically? > > > It is also customary to use double spaces when starting a new sentence. > > I thought this was the exce

Re: RFR: 8319324: FFM: Reformat javadocs [v3]

2023-11-06 Thread Jorn Vernee
On Mon, 6 Nov 2023 10:10:41 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v3]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 10:10:41 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v3]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

Re: RFR: 8319324: FFM: Reformat javadocs [v2]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v2]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v2]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 08:53:55 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> c

Re: RFR: 8319324: FFM: Reformat javadocs [v2]

2023-11-06 Thread Maurizio Cimadamore
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote: >> This PR proposes to reformat all the JavaDocs for the FFM API. This would >> bring the FFM API docs more in line with the existing Java documentation >> (see below). Occasional drive-by fixes are also included in this PR (such >> as spell

Re: RFR: 8319324: FFM: Reformat javadocs [v2]

2023-11-06 Thread Per Minborg
> This PR proposes to reformat all the JavaDocs for the FFM API. This would > bring the FFM API docs more in line with the existing Java documentation (see > below). Occasional drive-by fixes are also included in this PR (such as > spelling and capitalization). > > I am aware this PR will (if

RFR: 8319324: FFM: Reformat javadocs

2023-11-05 Thread Per Minborg
This PR proposes to reformat all the JavaDocs for the FFM API. This would bring the FFM API docs more in line with the existing Java documentation (see below). Occasional drive-by fixes are also included in this PR (such as spelling and capitalization). I am aware this PR will (if approved) ma