On Mon, 16 Oct 2023 11:28:36 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes in
On Sun, 15 Oct 2023 23:46:45 GMT, Chen Liang wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Blessed order
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 227:
>
>> 225: for (M
> Hi,
>
> Could I have a review of an enhancement that replaces the use of ASM with the
> new Class-File API. This change only deals with bytecode that writes event
> data into buffers. Bytecode transformations carried out by classes in
> jdk.jfr.internal.intrument package are kept as is. Plan
On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes in
On Mon, 16 Oct 2023 05:56:00 GMT, Chen Liang wrote:
>> I could not get it to work with findAttribute. No annotations were found.
>
> The existing code will silently finish the loop no-op and return `null` if no
> RVAA is present. So if `findAttribute` returns `Optional.empty()`, you should
> ju
On Mon, 16 Oct 2023 06:01:01 GMT, Chen Liang wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updates
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 256:
>
>> 254:
On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes in
On Mon, 16 Oct 2023 05:02:01 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line
>> 204:
>>
>>> 202: String typeDescriptor = classDesc.descriptorString();
>>> 203: for (ClassElement ce : classModel.elements()) {
>>> 204:
> Hi,
>
> Could I have a review of an enhancement that replaces the use of ASM with the
> new Class-File API. This change only deals with bytecode that writes event
> data into buffers. Bytecode transformations carried out by classes in
> jdk.jfr.internal.intrument package are kept as is. Plan
On Sun, 15 Oct 2023 23:45:05 GMT, Chen Liang wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updates
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 204:
>
>> 202: String typeD
On Sun, 15 Oct 2023 23:34:01 GMT, Chen Liang wrote:
>> Hi,
>>
>> Could I have a review of an enhancement that replaces the use of ASM with
>> the new Class-File API. This change only deals with bytecode that writes
>> event data into buffers. Bytecode transformations carried out by classes in
On Sun, 15 Oct 2023 20:20:48 GMT, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of an enhancement that replaces the use of ASM with the
> new Class-File API. This change only deals with bytecode that writes event
> data into buffers. Bytecode transformations carried out by classes in
> j
Hi,
Could I have a review of an enhancement that replaces the use of ASM with the
new Class-File API. This change only deals with bytecode that writes event data
into buffers. Bytecode transformations carried out by classes in
jdk.jfr.internal.intrument package are kept as is. Plan is to try to
13 matches
Mail list logo
