> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Wed, 18 Oct 2023 17:35:58 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Thu, 19 Oct 2023 12:22:29 GMT, Fei Yang wrote:
> Still good. You might want to correct the remaining typo.
Thanks for review!
-
PR Comment: https://git.openjdk.org/jdk/pull/16186#issuecomment-1770876188
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Thu, 19 Oct 2023 12:14:52 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Wed, 18 Oct 2023 17:35:58 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Tue, 17 Oct 2023 09:52:15 GMT, Ilya Gavrilin wrote:
>> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1682:
>>
>>> 1680: // use floating-point 1.0 with a sign of input
>>> 1681: is_double ? fsgnj_d(dst, one, src)
>>> 1682: : fsgnj_s(dst, one, src);
>>
>> What if the `
On Tue, 17 Oct 2023 09:09:52 GMT, Fei Yang wrote:
>> Ilya Gavrilin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix some registers usages and typos
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1682:
>
>> 1680: // use
On Mon, 16 Oct 2023 21:14:39 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
On Mon, 16 Oct 2023 21:14:39 GMT, Ilya Gavrilin wrote:
>> Hi all, please review this changes into risc-v floating point copysign and
>> signum intrinsics.
>> CopySign - returns first argument with the sign of second. On risc-v we have
>> `fsgnj.x` instruction, which can implement this intrinsic
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
> Signum - returns input value if it is +/- 0.0 or NaN, oth
On Fri, 13 Oct 2023 15:36:56 GMT, Ilya Gavrilin wrote:
> Hi all, please review this changes into risc-v floating point copysign and
> signum intrinsics.
> CopySign - returns first argument with the sign of second. On risc-v we have
> `fsgnj.x` instruction, which can implement this intrinsic.
>
Hi all, please review this changes into risc-v floating point copysign and
signum intrinsics.
CopySign - returns first argument with the sign of second. On risc-v we have
`fsgnj.x` instruction, which can implement this intrinsic.
Signum - returns input value if it is +/- 0.0 or NaN, otherwise 1.0
17 matches
Mail list logo