Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Naoto Sato
On Fri, 27 Oct 2023 22:21:41 GMT, Joe Wang wrote: >> src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java line 283: >> >>> 281: return type; >>> 282: } >>> 283: } >> >> Instead of looping through all the elements, `Enum.valueOf()` can

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Joe Wang
On Fri, 27 Oct 2023 20:41:59 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Impl CSR Changes: change the parameter type from String to Enum > > src/java.xml/share/classes/javax/xml/catalog/CatalogResol

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v6]

2023-10-27 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add IAE - Changes: - all: https://git.openjdk.org

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Naoto Sato
On Fri, 27 Oct 2023 19:20:01 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Im

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Lance Andersen
On Fri, 27 Oct 2023 19:16:33 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Im

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

2023-10-27 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Impl CSR Changes: change the parameter type from String to Enum

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v4]

2023-10-27 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/reba

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v3]

2023-10-06 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add a test for the NPE case - Changes: - all: htt

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v3]

2023-10-06 Thread Naoto Sato
On Fri, 6 Oct 2023 22:48:40 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

2023-10-06 Thread Joe Wang
On Fri, 6 Oct 2023 20:54:34 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addressing review comments, plus use URL for relative URI > > test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogTest.java line

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

2023-10-06 Thread Naoto Sato
On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

2023-10-06 Thread Joe Wang
On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang wrote: >> Add a new factory method so that a CatalogResolver can be created with a >> resolve property on top of the Catalog object. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add

Re: RFR: 8316996: Catalog API Enhancement: add a factory method [v2]

2023-10-06 Thread Joe Wang
> Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: addressing review comments, plus use URL for relative URI --

Re: RFR: 8316996: Catalog API Enhancement: add a factory method

2023-10-05 Thread Naoto Sato
On Wed, 4 Oct 2023 22:56:28 GMT, Joe Wang wrote: > Add a new factory method so that a CatalogResolver can be created with a > resolve property on top of the Catalog object. src/java.xml/share/classes/javax/xml/catalog/CatalogManager.java line 101: > 99: * and {@code ignore}. {@code null}

RFR: 8316996: Catalog API Enhancement: add a factory method

2023-10-04 Thread Joe Wang
Add a new factory method so that a CatalogResolver can be created with a resolve property on top of the Catalog object. - Commit messages: - 8316996: Catalog API Enhancement: add a factory method Changes: https://git.openjdk.org/jdk/pull/16045/files Webrev: https://webrevs.openjdk