Re: RFR: 8315585: Optimization for decimal to string [v3]

2025-01-30 Thread Shaojin Wen
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString > and BigDecimal::toPlainString performance and reduce duplicate code Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: remove getChars(long, int, char[]) -

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-10-11 Thread Shaojin Wen
> I submitted PR #1 before, and there were too many changes. I split it > into multiple PRs with small changes. This one is one of them. > > this PR removed the duplicate code for getChars in > BigDecimal#StringBuilderHelper, i also make performance faster. > Please review and don't hesitate

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-09-08 Thread 温绍锦
On Tue, 5 Sep 2023 18:13:39 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains four additional commits since >> t

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-09-05 Thread 温绍锦
On Tue, 5 Sep 2023 15:46:17 GMT, 温绍锦 wrote: >> BigDecimal is a commonly used class in business development, It is often >> necessary to perform toString or toPlainString operations on BigDecimal. >> >> The current version uses StringBuilder resulting in multiple memory >> allocations, I made a

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-09-05 Thread Claes Redestad
On Tue, 5 Sep 2023 15:46:17 GMT, 温绍锦 wrote: >> BigDecimal is a commonly used class in business development, It is often >> necessary to perform toString or toPlainString operations on BigDecimal. >> >> The current version uses StringBuilder resulting in multiple memory >> allocations, I made a

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-09-05 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because