On Mon, 28 Aug 2023 15:29:32 GMT, Alan Bateman wrote:
> > @AlanBateman Is there anything else you need me to do? If so, please let me
> > know. Thanks!
>
> I don't think the JDK is the right place to workaround this issue. Also, we
> really need to get back re-implementing FileInputStream and
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
> In this case, it seems a bit fragile to do it in CgroupUtil as it should be
> allowed to use any of the file system APIs to access cgroups or proc files.
In theory, yes. It should be able to use any file system APIs. Practically, it
doesn
On Thu, 24 Aug 2023 14:39:18 GMT, Severin Gehwolf wrote:
> I've now realized that the bug had an incorrect statement in the description.
> The cycle happens due to the `Runtime.getRuntime().maxMemory()`
> implementation in GraalVM to use JDK `Metrics`, since the `ByteBuffer` [code
> relies on
On Thu, 24 Aug 2023 13:37:36 GMT, Alan Bateman wrote:
> Something fishy here, is this working around a bug in GraaVM native image or
> why does this change need to be in JDK?
I've now realized that the bug had an incorrect statement in the description.
The cycle happens due to the `Runtime.get
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part of
the
JDK's Metrics API. The primary motivating factor is that it allows one to use
the
JDK's version of `Metrics` in GraalVM. See the bug for details as to why this is
needed.
Testing:
- [x] GraalVM builds with/withou
