Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 22:52:10 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/package-info.java line 109: > >> 107:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 21:51:01 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/package-info.java line 104: > >> 102:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Thu, 30 Nov 2023 22:39:26 GMT, Brent Christian wrote: >> IMO, the core of the semantics here are that the reachabilityFence() call >> happens before clearing or enqueueing of any References to the argument. I >> think it's the call itself, not the end of the argument.s scope (which may >> n

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Brent Christian
On Mon, 27 Nov 2023 22:33:16 GMT, Hans Boehm wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates to clear() and enqueue() > > src/java.base/share/classes/java/lang/ref/Reference.java line 546: > >> 544:

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-30 Thread Hans Boehm
On Thu, 25 Jan 2024 23:09:51 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v7]

2024-01-25 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer