Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-31 Thread Viktor Klang
On Wed, 22 May 2024 07:56:26 GMT, Alan Bateman wrote: >>> @bchristi-git Just checking inโ€”we're waiting for CSR-approval here before >>> integrating? ๐Ÿค” >> >> Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer >> โœ”๏ธs. ๐Ÿ˜‰ > >> Indeed - can't move forward without a CSR. Als

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-22 Thread Alan Bateman
On Tue, 21 May 2024 16:59:38 GMT, Brent Christian wrote: > Indeed - can't move forward without a CSR. Also wouldn't mind more reviewer > โœ”๏ธs. ๐Ÿ˜‰ I can do that. One other thing to do is to rebase the changes, it looks like this branch is 6 months behind main line. - PR Comment: ht

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-21 Thread Brent Christian
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed.

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-05-21 Thread Viktor Klang
On Wed, 17 Apr 2024 17:12:28 GMT, Brent Christian wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Another update to reachabilityFence() @apiNote > > AFAICT, all review feedback on this change has been addressed.

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-20 Thread Viktor Klang
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-17 Thread Brent Christian
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v22]

2024-04-05 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer