On Tue, 15 Aug 2023 16:38:42 GMT, Justin Lu wrote:
>> Please review this PR which is a broad clean up of the DigitList class (used
>> by Format classes in j.text).
>>
>> This PR is intended to be a portion of a bigger change (split up to make
>> reviewing easier).
>>
>> The main change simpl
> Please review this PR which is a broad clean up of the DigitList class (used
> by Format classes in j.text).
>
> This PR is intended to be a portion of a bigger change (split up to make
> reviewing easier).
>
> The main change simplifying related Rounding Mode logic in `shouldRoundUp()`
> -
On Mon, 14 Aug 2023 17:43:09 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/DigitList.java line 521:
>>
>>> 519: if (non0AfterIndex(maximumDigits)) {
>>> 520: return (isNegative && roundingMode ==
>>> RoundingMode.FLOOR)
>>> 521:
On Fri, 11 Aug 2023 22:33:08 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments (8/11/23)
>
> src/java.base/share/classes/java/text/DigitList.java line 521:
>
>> 519:
> Please review this PR which is a broad clean up of the DigitList class (used
> by Format classes in j.text).
>
> This PR is intended to be a portion of a bigger change (split up to make
> reviewing easier).
>
> The main change combines related Rounding Mode logic in `shouldRoundUp()` -
> (_
On Fri, 11 Aug 2023 18:27:47 GMT, Justin Lu wrote:
> Please review this PR which is a broad clean up of the DigitList class (used
> by Format classes in j.text).
>
> This PR is intended to be a portion of a bigger change (split up to make
> reviewing easier).
>
> The main change combines rel
Please review this PR which is a broad clean up of the DigitList class (used by
Format classes in j.text).
This PR is intended to be a portion of a bigger change (split up to make
reviewing easier).
The main change combines related Rounding Mode logic in `shouldRoundUp()` -
(_CEILING/FLOOR_,
