Re: RFR: 8313205: Modernize java.text.Format with StringBuilder [v3]

2024-08-23 Thread Justin Lu
> Please review this PR which adds public StringBuilder overloads to the > formatting methods of java.text.Format and implementing subclasses. > > While Format, NumberFormat, and DateFormat are abstract, these new methods > are not added as abstract to prevent compatibility concerns. Instead the

Re: RFR: 8313205: Modernize java.text.Format with StringBuilder

2024-07-25 Thread Justin Lu
On Thu, 25 Jul 2024 23:28:44 GMT, Chen Liang wrote: > You should add `@since` tags on all these new API additions. Thanks for the reminder. Updated. - PR Comment: https://git.openjdk.org/jdk/pull/20337#issuecomment-2251577718

Re: RFR: 8313205: Modernize java.text.Format with StringBuilder [v2]

2024-07-25 Thread Justin Lu
> Please review this PR which adds public StringBuilder overloads to the > formatting methods of java.text.Format and implementing subclasses. > > While Format, NumberFormat, and DateFormat are abstract, these new methods > are not added as abstract to prevent compatibility concerns. Instead the

Re: RFR: 8313205: Modernize java.text.Format with StringBuilder

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 22:18:03 GMT, Justin Lu wrote: > Please review this PR which adds public StringBuilder overloads to the > formatting methods of java.text.Format and implementing subclasses. > > While Format, NumberFormat, and DateFormat are abstract, these new methods > are not added as ab

RFR: 8313205: Modernize java.text.Format with StringBuilder

2024-07-25 Thread Justin Lu
Please review this PR which adds public StringBuilder overloads to the formatting methods of java.text.Format and implementing subclasses. While Format, NumberFormat, and DateFormat are abstract, these new methods are not added as abstract to prevent compatibility concerns. Instead they are adde