On Thu, 13 Jul 2023 08:31:37 GMT, Aleksey Shipilev wrote:
> Clean backport. Fixes the regression introduced in JDK 21.
Test failures in GHA are unrelated.
-
PR Comment: https://git.openjdk.org/jdk21/pull/120#issuecomment-1634114884
On Thu, 13 Jul 2023 08:31:37 GMT, Aleksey Shipilev wrote:
> Clean backport. Fixes the regression introduced in JDK 21.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/120#pullrequestreview-1527931960
Clean backport. Fixes the regression introduced in JDK 21.
-
Commit messages:
- Backport 401c3dea5d8823bc9c0f40506ddad46e983ebf68
Changes: https://git.openjdk.org/jdk21/pull/120/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=120&range=00
Issue: https://bugs.openjdk.org/
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14809#pullrequestreview-1524357337
On Mon, 10 Jul 2023 18:28:08 GMT, Jenny Shivayogi wrote:
>> Hi @kspeeyu ,
>>
>> Thanks for fixing this issue. The fix looks good except the whitespace issue
>> already mentioned before.
>>
>> Notice that we don't use TABs for code indentation in OpenJDK. For the
>> native Hotspot sources (i.e
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14809#pullrequestreview-1523459114
On Mon, 10 Jul 2023 18:38:11 GMT, Aleksey Shipilev wrote:
> Hold on a sec, let's make sure the GitHub Actions complete with all green. We
> can techinically wait after `/integrate` is said for sponsored changeset, but
> it is cleaner process-wise to wait for GHA all-clear/all-green.
Sure thing
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Hold on a sec, let's make sure the GitHub Actions complete with all green. We
can techinically wait after `/integrate` is said for sponsored changeset,
On Mon, 10 Jul 2023 16:38:26 GMT, Volker Simonis wrote:
>> Free-ing 'buf' before two conditional return statements introduced by
>> JDK-8307990
>
> Hi @kspeeyu ,
>
> Thanks for fixing this issue. The fix looks good except the whitespace issue
> already mentioned before.
>
> Notice that we don
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Thanks, looks good now.
I can sponsor your change once you `/integrate`.
-
Marked as reviewed by simonis (Reviewer).
PR Review: https://g
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Looks good!
-
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14809#pullrequestreview-1522691783
On Mon, 10 Jul 2023 11:12:36 GMT, Aleksey Shipilev wrote:
>> Free-ing 'buf' before two conditional return statements introduced by
>> JDK-8307990
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c line 575:
>
>> 573: writeFully(c->childenv[1], buf, bufsize) != bufsize) {
>> 574:
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Hi @kspeeyu ,
Thanks for fixing this issue. The fix looks good except the whitespace issue
already mentioned before.
Notice that we don't use TABs for
On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Looks okay, but need to fix two whitespace errors for jcheck to be happy.
Also, attention @simonis, whose patch introduced this little problem, I think.
Free-ing 'buf' before two conditional return statements introduced by
JDK-8307990
-
Commit messages:
- removing tab space and resolving merge conflict
- Merge branch 'openjdk:master' into JDK-8311645
- removing tab space
- freeing the buf before return
- removing tab space
Chan
15 matches
Mail list logo
