Re: RFR: 8311220: Optimization for StringLatin UpperLower [v12]

2023-09-18 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v11]

2023-09-18 Thread Claes Redestad
On Mon, 18 Sep 2023 15:00:20 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v11]

2023-09-18 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v7]

2023-09-18 Thread Roger Riggs
On Mon, 4 Sep 2023 06:50:18 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v10]

2023-09-18 Thread Claes Redestad
On Mon, 18 Sep 2023 04:11:25 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-18 Thread Claes Redestad
On Mon, 18 Sep 2023 03:00:25 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains ten additional commits since the >> l

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v10]

2023-09-18 Thread Chen Liang
On Mon, 18 Sep 2023 04:11:25 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v10]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread 温绍锦
On Mon, 18 Sep 2023 03:00:25 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains ten additional commits since the >> l

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v9]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread Chen Liang
On Mon, 18 Sep 2023 02:53:18 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_deta

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v7]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 17:54:02 GMT, Claes Redestad wrote: > The preferred route is to merge in then push changes from master to your PR > branch. Merge will cause a lot of file changes > `hasNotUpperCaseEx` sounds wrong. `hasUpperCaseMapping`? i have renamed hasNotUpperCaseEx to hasUpperCaseMapp

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v6]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread Claes Redestad
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread Claes Redestad
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v4]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 12:33:18 GMT, Claes Redestad wrote: > The two odd codepoints I was curious about are `0xaa` and `0xba`, both of > which are lower-case according to `Character.isLowerCase(..)` but does not > actually have an uppercase. The Unicode data categorize these two as `Lo`, > Letter,

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v4]

2023-09-03 Thread Claes Redestad
On Fri, 1 Sep 2023 18:44:13 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-09-01 Thread 温绍锦
On Thu, 31 Aug 2023 11:45:31 GMT, Claes Redestad wrote: > I think this overall looks reasonable, but I think a more thorough proof / > test would help to build confidence that all these changes are semantically > neutral. > > The `isLowerCaseEx` needs to explain why two lower-case codepoints a

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-09-01 Thread 温绍锦
On Thu, 31 Aug 2023 11:39:57 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add method CharacterDataLatin1#isLowerCaseEx > > src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v4]

2023-09-01 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-08-31 Thread Claes Redestad
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-08-30 Thread 温绍锦
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-08-25 Thread 温绍锦
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-08-23 Thread 温绍锦
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-08-05 Thread 温绍锦
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v3]

2023-07-05 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v2]

2023-07-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread Glavo
On Mon, 3 Jul 2023 09:21:54 GMT, 温绍锦 wrote: > another example: > > ``` > String str0 = new String(new byte[]{-1}, StandardCharsets.ISO_8859_1); > String str1 = str0.toUpperCase(); > ``` > > str0.coder is LATIN1 str1.coder is UTF16 I know this, these cases only happen with `toUpperCase`, not wi

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread 温绍锦
On Mon, 3 Jul 2023 09:20:04 GMT, Glavo wrote: >> String str0 = new String(new byte[]{-75}, StandardCharsets.ISO_8859_1); >> String str1 = str0.toUpperCase(); >> >> str0.coder is LATIN1 >> str1.coder is UTF16 > >> ```java >> String str0 = new String(new byte[]{-75}, StandardCharsets.ISO_8859_1);

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread Glavo
On Mon, 3 Jul 2023 09:17:29 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/lang/StringLatin1.java line 442: >> >>> 440: if (!canEncode(cp)) { // not a latin1 >>> character >>> 441: return toLowerCaseEx(str, value, first, locale, false); >>>

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread 温绍锦
On Mon, 3 Jul 2023 08:25:06 GMT, Glavo wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_det

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread Glavo
On Mon, 3 Jul 2023 04:02:44 GMT, 温绍锦 wrote: > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.htm

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-03 Thread Chen Liang
On Mon, 3 Jul 2023 05:29:57 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/lang/StringLatin1.java line 498: >> >>> 496: for (first = 0 ; first < len; first++ ) { >>> 497: int cp = value[first] & 0xff; >>> 498: if (cp >= 'a' && (cp <= 'z' || cp == 181 || (cp >

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-02 Thread 温绍锦
On Mon, 3 Jul 2023 05:16:35 GMT, Jacob G. wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_

Re: RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-02 Thread Jacob G .
On Mon, 3 Jul 2023 04:02:44 GMT, 温绍锦 wrote: > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.htm

RFR: 8311220: Optimization for StringLatin UpperLower

2023-07-02 Thread 温绍锦
# Benchmark Result sh make/devkit/createJMHBundle.sh bash configure --with-jmh=build/jmh/jars make test TEST="micro:java.lang.StringUpperLower.*" ## 1. [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) * cpu : intel xeon sapphire rapids (x64) ``` diff -Benchmark