Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v5]

2023-07-18 Thread Lance Andersen
On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> `equals` and `hashCode` in the java.text area. >> >> * Some changes to `equals` and `hashCode` are refactoring rather than >> modernization. Such changes can be

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v5]

2023-07-18 Thread Roger Riggs
On Mon, 17 Jul 2023 23:33:37 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> `equals` and `hashCode` in the java.text area. >> >> * Some changes to `equals` and `hashCode` are refactoring rather than >> modernization. Such changes can be

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v5]

2023-07-17 Thread Pavel Rappo
On Wed, 12 Jul 2023 22:26:14 GMT, John R Rose wrote: > Yes, it would be, because `rp` has a statically observable type, > `BigInteger`. And that observation will flow across the call to the helper > method. After all, my mental model is incorrect; sigh. I read your write-up as though once we

Re: RFR: 8311188: Simplify and modernize equals and hashCode in java.text [v5]

2023-07-17 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > `equals` and `hashCode` in the java.text area. > > * Some changes to `equals` and `hashCode` are refactoring rather than > modernization. Such changes can be as trivial as rearranging, adding, or > commenting checks.