Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Our tier 1 builds have passed. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14645#pullrequestreview-1497595990

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 04:26:47 GMT, David Holmes wrote: > > as is evident in the tests for this PR > > You mean the GHA builds? They don't seem to be building the failing > `jdk.jdwp.agent-static-libs` target. I can't recompile the JDK at the moment to compile ArrayReferenceImpl.c, but I can de

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Okay I have it running through our tier1 builds at the moment. If that passes I will approve the PR. Thanks - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606580347

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 04:23:58 GMT, Julian Waters wrote: > as is evident in the tests for this PR You mean the GHA builds? They don't seem to be building the failing `jdk.jdwp.agent-static-libs` target. - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606573575

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 How was the original change tested? How was this change tested? - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606571300

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 04:15:09 GMT, David Holmes wrote: > https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 :/ > How was the original change tested? How was this change tested? I made the mistake of testing the original on gcc instead of the native compiler for Wind

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 _Alignas does work on Microsoft Visual C, fortunately - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606570803

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread David Holmes
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606567568

Re: RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage @dholmes-ora - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606505881

RFR: 8310863: Build failure after JDK- 8305341

2023-06-25 Thread Julian Waters
Microsoft, your C "conformance" is garbage - Commit messages: - ArrayReferenceImpl.c - GSSLibStub.c - 8310863 Changes: https://git.openjdk.org/jdk/pull/14645/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310863