On Mon, 26 Jun 2023 23:02:29 GMT, Mandy Chung wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
>> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>>
>> The comm
> Hi all,
>
> This pull request contains a backport of commit
> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Mandy Chung on 26 Jun 2023
On Mon, 26 Jun 2023 21:58:41 GMT, Chen Liang wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
>> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>>
>> The commi
On Mon, 26 Jun 2023 20:25:40 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
Hi all,
This pull request contains a backport of commit
[7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mandy Chung on 26 Jun 2023 and was
revi
On Thu, 22 Jun 2023 17:47:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Thu, 22 Jun 2023 17:47:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Thu, 22 Jun 2023 17:47:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Thu, 22 Jun 2023 16:49:05 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/Class.java line 426:
>>
>>> 424: /**
>>> 425: * Returns the {@code Class} object associated with the class or
>>> 426: * interface with the given string name, using the given class
>>> lo
On Thu, 22 Jun 2023 00:49:17 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/java.base/share/classes/java/lang/Class.java line 426:
>
>> 424: /**
>> 425: * Returns t
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Wed, 21 Jun 2023 23:06:23 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits s
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request with a new target base due to a merge
or a rebase. The incr
On Wed, 21 Jun 2023 09:54:53 GMT, Alan Bateman wrote:
>> Binary name is a long-standing behavior. It's a spec bug.
>
>> Binary name is a long-standing behavior. It's a spec bug.
>
> Yes, I view this PR as just specifying long standing behavior. The name used
> for array class may be surprising
On Tue, 20 Jun 2023 17:45:03 GMT, Mandy Chung wrote:
> Binary name is a long-standing behavior. It's a spec bug.
Yes, I view this PR as just specifying long standing behavior. The name used
for array class may be surprising but I don't think it can be changed.
-
PR Review Comment:
On Mon, 19 Jun 2023 01:34:59 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Class.java line 395:
>>
>>> 393: * attached thread), the system class loader is used.
>>> 394: *
>>> 395: * @param className the binary name
>>> of the class
>>
>> Where do these l
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Sat, 17 Jun 2023 13:56:15 GMT, Alan Bateman wrote:
> This changes look okay but they do make me wonder if we should add a note to
> the 2-arg Class.forName to make it clear that it does not allow class names
> for array types, the class name has to be a binary name.
In its specification:
"T
On Sun, 18 Jun 2023 18:54:22 GMT, Jens Lidestrom wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> missing 'L' for the array class name
>
> src/java.base/share/classes/java/lang/Class.java line 395:
>
>> 393: *
On Sun, 18 Jun 2023 18:36:28 GMT, Jens Lidestrom wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> missing 'L' for the array class name
>
> src/java.base/share/classes/java/lang/Class.java line 395:
>
>> 393: *
On Sun, 18 Jun 2023 18:56:39 GMT, Jens Lidestrom wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> missing 'L' for the array class name
>
> src/java.base/share/classes/java/lang/Class.java line 427:
>
>> 425: *
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Fri, 16 Jun 2023 23:18:48 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comment
>
> src/java.base/share/classes/java/lang/Class.java line 443:
>
>> 441: * If {@code name} denotes a
On Fri, 16 Jun 2023 21:33:44 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Fri, 16 Jun 2023 21:33:44 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Fri, 16 Jun 2023 21:23:17 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify for an array class of primitive type
>
> src/java.base/share/classes/java/lang/Class.java line 448:
>
>> 446:
On Fri, 16 Jun 2023 21:24:17 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Fri, 16 Jun 2023 20:15:25 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify for an array class of primitive type
>
> src/java.base/share/classes/java/lang/Class.java line 444:
>
>> 442:
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Fri, 16 Jun 2023 19:58:08 GMT, Mandy Chung wrote:
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
src/java.base/share/classes/java/lang/Class.ja
This PR clarifies the spec of the 3-arg Class::forName regarding the format of
the name for an array type which is of the form: one or more of "[" + binary
name of the element type + ";'.
-
Commit messages:
- 8310242: Clarify the name parameter to Class::forName
Changes: https://
43 matches
Mail list logo
