On Thu, 22 Jun 2023 20:41:33 GMT, Justin Lu wrote:
>> Please review this PR as apart of
>> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
>> some tests in Locale to use JUnit. Other cleanup and small changes are
>> included as well. More refactoring in Locale tests
On Thu, 22 Jun 2023 20:02:12 GMT, Naoto Sato wrote:
>> Unless I am mistaken, both bug IDs, 4122700 8282319 are in the combined file.
>
> Yes. I wanted to make it clear that this `nonEmptyLocalesTest` was for the
> issue 4122700.
Sorry, I totally misread you said 'method'. Fixed `nonEmptyLocales
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will be done in separate
> PRs.
>
> If the test had a b
On Thu, 22 Jun 2023 19:23:27 GMT, Justin Lu wrote:
>> test/jdk/java/util/Locale/AvailableLocalesTest.java line 46:
>>
>>> 44: /**
>>> 45: * Test that Locale.getAvailableLocales() is non-empty.
>>> 46: * Print out the locales.
>>
>> If you combine two tests into a single one, I'd p
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will be done in separate
> PRs.
>
> If the test had a b
On Thu, 22 Jun 2023 18:47:06 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Method signature is too long
>> - Exceptions in GetInstanceCheck.java are distinct, catch clause should be
>> reserved
On Thu, 22 Jun 2023 18:55:31 GMT, Justin Lu wrote:
>> Please review this PR as apart of
>> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
>> some tests in Locale to use JUnit. Other cleanup and small changes are
>> included as well. More refactoring in Locale tests
On Thu, 22 Jun 2023 18:34:26 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: Clarify LocaleConstructors.java with comment for each test method
>
> test/jdk/java/util/Locale/LocaleConstructo
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will be done in separate
> PRs.
>
> If the test had a b
On Thu, 22 Jun 2023 18:30:55 GMT, Lance Andersen wrote:
>> test/jdk/java/util/Locale/LocaleConstructors.java line 51:
>>
>>> 49: public void langTest() {
>>> 50: Locale aLocale = Locale.of(LANG);
>>> 51: Locale otherLocale = new Locale(LANG);
>>
>> Is there a preference on t
On Thu, 22 Jun 2023 01:08:30 GMT, Justin Lu wrote:
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will
On Thu, 22 Jun 2023 18:25:24 GMT, Justin Lu wrote:
>> Please review this PR as apart of
>> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
>> some tests in Locale to use JUnit. Other cleanup and small changes are
>> included as well. More refactoring in Locale tests
On Thu, 22 Jun 2023 01:08:30 GMT, Justin Lu wrote:
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will
Please review this PR as apart of
[JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors some
tests in Locale to use JUnit. Other cleanup and small changes are included as
well. More refactoring in Locale tests will be done in separate PRs.
If the test had a bugN.java na
14 matches
Mail list logo
