Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-13 Thread Roger Riggs
On Tue, 13 Jun 2023 20:20:32 GMT, Stuart Marks wrote: > Hi all, > > This pull request contains a backport of commit > [e1386856](https://github.com/openjdk/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-13 Thread Stuart Marks
Hi all, This pull request contains a backport of commit [e1386856](https://github.com/openjdk/jdk/commit/e138685648fb7a756a05f314af2883ce408abdd2) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Stuart Marks on 13 Jun 2023 and was rev

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-13 Thread Roger Riggs
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1477284507

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Jaikiran Pai
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1476287791

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Stuart Marks
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. I've been advised by @jddarcy to file a CSR for this, in order to track of serialization compatibility issues. - PR Comment: https://git.openjdk.org/jdk/pull/14433#issuecomment-1588346239

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Brian Burkhalter
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. Looks fine. - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14433#pullrequestreview-1476004322

Re: RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Joe Darcy
On Tue, 13 Jun 2023 00:03:35 GMT, Stuart Marks wrote: > Make `putMode` be a transient field. I skimmed the JDK-8266571: "Sequenced Collections" and didn't see any similar instances, but it would benefit from another look. - Marked as reviewed by darcy (Reviewer). PR Review: https

RFR: 8309882: LinkedHashMap adds an errant serializable field

2023-06-12 Thread Stuart Marks
Make `putMode` be a transient field. - Commit messages: - 8309882: LinkedHashMap adds an errant serializable field Changes: https://git.openjdk.org/jdk/pull/14433/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14433&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309