Re: RFR: 8309408: Thread.sleep cleanup [v2]

2023-06-15 Thread Alan Bateman
> Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now so we can do some small cleanups that came up in PR >

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-15 Thread Alan Bateman
On Mon, 5 Jun 2023 19:44:35 GMT, Alan Bateman wrote: > > I think we need to delay this until > > [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in > > case we would like to revert > > [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305092). > > Okay, I won't integr

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-12 Thread Sergey Tsypanov
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-06 Thread Alan Bateman
On Mon, 5 Jun 2023 20:05:24 GMT, Chris Plummer wrote: > The following commit in loom heavily modified this file with a lot of added > expected methods. There are other related tests with similar changes. I'm not > so sure I understand the need for so many additions, and also why > expectedLeng

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread Chris Plummer
On Mon, 5 Jun 2023 15:10:18 GMT, Alan Bateman wrote: >> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java >> line 660: >> >>> 658: expectedMethods.add(Thread.class.getName() + ".sleep"); >>> 659: expectedMethods.add(Thread.class.getName() + ".sleepNanos");

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread Alan Bateman
On Mon, 5 Jun 2023 17:25:43 GMT, Aleksey Shipilev wrote: > I think we need to delay this until > [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in > case we would like to revert > [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305092). Okay, I won't integrate this

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread Aleksey Shipilev
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread Alan Bateman
On Mon, 5 Jun 2023 07:26:57 GMT, David Holmes wrote: >> Thread.sleep has had quite a bit of churn recently to support virtual >> threads, add sleep(Duration), a JFR event, and the change the underlying >> implementation to support sub-millis precision. I think the changes have >> settled down

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread Stefan Karlsson
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now

Re: RFR: 8309408: Thread.sleep cleanup

2023-06-05 Thread David Holmes
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now

RFR: 8309408: Thread.sleep cleanup

2023-06-04 Thread Alan Bateman
Thread.sleep has had quite a bit of churn recently to support virtual threads, add sleep(Duration), a JFR event, and the change the underlying implementation to support sub-millis precision. I think the changes have settled down now so we can do some small cleanups that came up in PR discussions