Re: RFR: 8308591: JLine as the default Console provider [v6]

2023-07-18 Thread Alan Bateman
On Tue, 18 Jul 2023 17:08:34 GMT, Naoto Sato wrote: >> This is to bring the JLine-based Console implementation as the default, >> which was the initial intention in >> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding >> CSR has also been drafted. > > Naoto Sato has u

Re: RFR: 8308591: JLine as the default Console provider [v6]

2023-07-18 Thread Naoto Sato
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Naoto Sato has updated the pull request incrementally with two additional co

Re: RFR: 8308591: JLine as the default Console provider [v5]

2023-07-18 Thread Naoto Sato
On Tue, 18 Jul 2023 15:21:50 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> `true` > > src/java.base/share/classes/java/io/Console.java line 354: > >> 352: * character devices are available t

Re: RFR: 8308591: JLine as the default Console provider [v5]

2023-07-18 Thread Alan Bateman
On Mon, 17 Jul 2023 20:46:32 GMT, Naoto Sato wrote: >> This is to bring the JLine-based Console implementation as the default, >> which was the initial intention in >> [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding >> CSR has also been drafted. > > Naoto Sato has u

Re: RFR: 8308591: JLine as the default Console provider [v5]

2023-07-17 Thread Naoto Sato
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional co

Re: RFR: 8308591: JLine as the default Console provider [v4]

2023-07-17 Thread Naoto Sato
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional co

Re: RFR: 8308591: JLine as the default Console provider [v3]

2023-07-17 Thread Naoto Sato
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional co

Re: RFR: 8308591: JLine as the default Console provider [v2]

2023-07-17 Thread Naoto Sato
> This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Naoto Sato has updated the pull request with a new target base due to a merge

Re: RFR: 8308591: JLine as the default Console provider

2023-07-17 Thread Naoto Sato
On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato wrote: > This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. Thanks, Alan. > This lo

Re: RFR: 8308591: JLine as the default Console provider

2023-07-17 Thread Alan Bateman
On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato wrote: > This is to bring the JLine-based Console implementation as the default, which > was the initial intention in > [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding > CSR has also been drafted. This looks quite good. I

RFR: 8308591: JLine as the default Console provider

2023-07-14 Thread Naoto Sato
This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted. - Commit messages: - javadoc cleanup - Merge branch 'master' into JDK-