On Fri, 19 May 2023 08:26:31 GMT, Viktor Klang wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of a weak reference so that it no longer associated with th
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
On Fri, 19 May 2023 09:09:05 GMT, Alan Bateman wrote:
> There is more significant work to do this area and I think we can look at it
> then.
That sounds reasonable to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/14047#issuecomment-1554277576
On Fri, 19 May 2023 08:46:24 GMT, Jaikiran Pai wrote:
> Would it be worth calling `expungeStaleEntries()` to do this cleanup even
> when a specific `ThreadContainer` is deregistered, in the implementation of
> method `deregisterContainer(...)`?
If there is a mix of usages where some are explic
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
ThreadContainers is an internal class used to make thread pools and other
groupings of threads discoverable for observability. Some refactoring in 2021
(in the loom repo, and before integration) accidentally changed the creation of
a weak reference so that it no longer associated with the refere
