Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-06 Thread Stuart Marks
On Tue, 6 Jun 2023 04:55:10 GMT, Jaikiran Pai wrote: >> Adjust the specification of the `SequencedMap` sequenced-view methods, and >> adjust implementations to match. > > src/java.base/share/classes/java/util/SequencedMap.java line 268: > >> 266: * Its {@link SequencedSet#reversed reversed

Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-06 Thread Stuart Marks
On Tue, 6 Jun 2023 04:58:46 GMT, Jaikiran Pai wrote: >> Adjust the specification of the `SequencedMap` sequenced-view methods, and >> adjust implementations to match. > > src/java.base/share/classes/java/util/AbstractMap.java line 908: > >> 906: public boolean add(E t) { throw uoe(); }

Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-06 Thread Alan Bateman
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote: > Adjust the specification of the `SequencedMap` sequenced-view methods, and > adjust implementations to match. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14267#pullrequestreview-146486

Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-05 Thread Joe Darcy
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote: > Adjust the specification of the `SequencedMap` sequenced-view methods, and > adjust implementations to match. Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14267#pullrequestreview-146426

Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-05 Thread Jaikiran Pai
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote: > Adjust the specification of the `SequencedMap` sequenced-view methods, and > adjust implementations to match. src/java.base/share/classes/java/util/AbstractMap.java line 908: > 906: public boolean add(E t) { throw uoe(); } > 907:

Re: RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-05 Thread Jaikiran Pai
On Thu, 1 Jun 2023 16:18:12 GMT, Stuart Marks wrote: > Adjust the specification of the `SequencedMap` sequenced-view methods, and > adjust implementations to match. src/java.base/share/classes/java/util/SequencedMap.java line 268: > 266: * Its {@link SequencedSet#reversed reversed} method

RFR: 8307840: SequencedMap view method specification and implementation adjustments

2023-06-01 Thread Stuart Marks
Adjust the specification of the `SequencedMap` sequenced-view methods, and adjust implementations to match. - Commit messages: - Minor wording adjustment. - 8307840: SequencedMap view method specification and implementation adjustments Changes: https://git.openjdk.org/jdk/pull/14